content/browser/service_worker/embedded_worker_test_helper.h - Issue 1636483002: Update the PushEvent to have a nullable PushMessageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.h

Issue 1636483002: Update the PushEvent to have a nullable PushMessageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review comments and include Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/push_messaging/push_messaging_router.cc ('k') | content/browser/service_worker/embedded_worker_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_test_helper.h

diff --git a/content/browser/service_worker/embedded_worker_test_helper.h b/content/browser/service_worker/embedded_worker_test_helper.h

index 10c71699de1769ec5706c30a1616d974d6a186e2..3de05bd023884a0d9676c70b29f6d571fd26c289 100644

--- a/content/browser/service_worker/embedded_worker_test_helper.h

+++ b/content/browser/service_worker/embedded_worker_test_helper.h

@@ -30,6 +30,7 @@ class EmbeddedWorkerRegistry;

class EmbeddedWorkerTestHelper;

class MessagePortMessageFilter;

class MockRenderProcessHost;

+struct PushEventPayload;

class ServiceWorkerContextCore;

class ServiceWorkerContextWrapper;

struct ServiceWorkerFetchRequest;

@@ -125,7 +126,7 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,

const ServiceWorkerFetchRequest& request);

virtual void OnPushEvent(int embedded_worker_id,

int request_id,

- const std::string& data);

+ const PushEventPayload& payload);

// These functions simulate sending an EmbeddedHostMsg message to the

// browser.

@@ -152,7 +153,7 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,

void OnInstallEventStub(int request_id);

void OnFetchEventStub(int request_id,

const ServiceWorkerFetchRequest& request);

- void OnPushEventStub(int request_id, const std::string& data);

+ void OnPushEventStub(int request_id, const PushEventPayload& payload);

void OnSetupMojoStub(int thread_id,

mojo::InterfaceRequest<mojo::ServiceProvider> services,

mojo::ServiceProviderPtr exposed_services);