content/browser/browser_context.cc - Issue 1636483002: Update the PushEvent to have a nullable PushMessageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_context.cc

Issue 1636483002: Update the PushEvent to have a nullable PushMessageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review comments and include Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_unittest.cc ('k') | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_context.cc

diff --git a/content/browser/browser_context.cc b/content/browser/browser_context.cc

index fc3f644fba214656908804ba9084f8770210ac99..32681ae71dba4e25bb1f9e5022c8461a0673946f 100644

--- a/content/browser/browser_context.cc

+++ b/content/browser/browser_context.cc

@@ -255,11 +255,12 @@ void BrowserContext::DeliverPushMessage(

BrowserContext* browser_context,

const GURL& origin,

int64_t service_worker_registration_id,

- const std::string& data,

+ const PushEventPayload& payload,

const base::Callback<void(PushDeliveryStatus)>& callback) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- PushMessagingRouter::DeliverMessage(

- browser_context, origin, service_worker_registration_id, data, callback);

+ PushMessagingRouter::DeliverMessage(browser_context, origin,

+ service_worker_registration_id, payload,

+ callback);

}

// static