third_party/WebKit/Source/modules/modules.gypi - Issue 1636483002: Update the PushEvent to have a nullable PushMessageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/modules.gypi

Issue 1636483002: Update the PushEvent to have a nullable PushMessageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and integrate OWNERS code review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/embedded_worker_test_helper.h ('K') | « content/renderer/service_worker/service_worker_context_client.cc ('k') | third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp » ('j') | third_party/WebKit/Source/modules/push_messaging/PushMessageDataTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/modules.gypi

diff --git a/third_party/WebKit/Source/modules/modules.gypi b/third_party/WebKit/Source/modules/modules.gypi

index 47a7a4d68ea2092329f003eb9f789b051b8027a5..856e6e70cd499701c4abfb1ddc9db9ca5c4c7a04 100644

--- a/third_party/WebKit/Source/modules/modules.gypi

+++ b/third_party/WebKit/Source/modules/modules.gypi

@@ -1906,6 +1906,7 @@

'mediastream/RTCDataChannelTest.cpp',

'notifications/NotificationDataTest.cpp',

'presentation/PresentationAvailabilityTest.cpp',

+ 'push_messaging/PushMessageDataTest.cpp',

'serviceworkers/ServiceWorkerContainerTest.cpp',

'webaudio/AudioBasicProcessorHandlerTest.cpp',

'webaudio/ConvolverNodeTest.cpp',