Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.h

Issue 1636483002: Update the PushEvent to have a nullable PushMessageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/push_messaging/push_messaging_service_impl.h
diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.h b/chrome/browser/push_messaging/push_messaging_service_impl.h
index e215ea460d7e649a435bec648a8b4078636510e6..449154b9426a8e321279616975b9bf8ce2507d54 100644
--- a/chrome/browser/push_messaging/push_messaging_service_impl.h
+++ b/chrome/browser/push_messaging/push_messaging_service_impl.h
@@ -24,6 +24,7 @@
#include "components/keyed_service/core/keyed_service.h"
#include "content/public/browser/push_messaging_service.h"
#include "content/public/common/permission_status.mojom.h"
+#include "content/public/common/push_event_payload.h"
#include "content/public/common/push_messaging_status.h"
#include "third_party/WebKit/public/platform/modules/push_messaging/WebPushPermissionStatus.h"
@@ -213,7 +214,7 @@ class PushMessagingServiceImpl : public content::PushMessagingService,
base::Callback<void(const std::string& app_id,
const GURL& origin,
int64_t service_worker_registration_id,
- const std::string& message_data)>;
+ const content::PushEventPayload& payload)>;
void SetMessageDispatchedCallbackForTesting(
const MessageDispatchedCallback& callback) {

Powered by Google App Engine
This is Rietveld 408576698