Update Token Binding code to match latest draft draft-ietf-tokbind-protocol-04

Update Token Binding code to match latest draft draft-ietf-tokbind-protocol-04

BUG=467312
Committed: https://crrev.com/47d408a4847886b442365a41ef8281ca99de0812
Cr-Commit-Position: refs/heads/master@{#372198}

[nharper, 2016-01-26 23:10:45]

nharper@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2016-01-28 18:27:55]

One quick question. Otherwise looks good.

https://codereview.chromium.org/1636453004/diff/1/net/socket/ssl_client_socke...
File net/socket/ssl_client_socket_openssl.cc (right):

https://codereview.chromium.org/1636453004/diff/1/net/socket/ssl_client_socke...
net/socket/ssl_client_socket_openssl.cc:92: const uint8_t
kTbMinProtocolVersionMinor = 3;
Where did these numbers come from? I don't see them in the spec. (It's possible
I'm just failing to find it.)

[nharper, 2016-01-28 19:06:08]

https://codereview.chromium.org/1636453004/diff/1/net/socket/ssl_client_socke...
File net/socket/ssl_client_socket_openssl.cc (right):

https://codereview.chromium.org/1636453004/diff/1/net/socket/ssl_client_socke...
net/socket/ssl_client_socket_openssl.cc:92: const uint8_t
kTbMinProtocolVersionMinor = 3;
On 2016/01/28 18:27:55, davidben (slow) wrote:
> Where did these numbers come from? I don't see them in the spec. (It's
possible
> I'm just failing to find it.)

This comes from draft-ietf-tokbind-negotiation-02, section 2: "Prototype
implementations of Token Binding drafts can indicate support of a specific draft
version, e.g. {0, 1} or {0, 2}."

Since draft-ietf-tokbind-protocol-04 is the latest spec, I'm assuming that {0,4}
is the ProtocolVersion to indicate. The min version {0,3} comes from me looking
through the previous drafts to see what is compatible with the latest version.
The only change (relevant to the implementation) in draft 04 was to move the
TokenBindingType from one struct to another, but it ends up serialized the same
on the wire, so it's compatible with the previous version. It's not compatible
with {0,2}.

You may notice that this code previously indicated it supported versions {0,2}
and {0,3}. I believe that was a bug in the code.

[davidben, 2016-01-28 19:20:40]

lgtm

[nharper, 2016-01-28 19:21:11]

The CQ bit was checked by nharper@chromium.org

[commit-bot: I haz the power, 2016-01-28 19:22:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636453004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636453004/1

[commit-bot: I haz the power, 2016-01-28 19:58:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 19:58:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nharper, 2016-01-28 21:07:41]

Bump TB version in tlslite

[nharper, 2016-01-28 21:08:51]

ptal. I forgot to bump the version in tlslite as well, which caused tests to
fail.

[davidben, 2016-01-28 21:13:15]

still lgtm

[nharper, 2016-01-28 21:36:50]

The CQ bit was checked by nharper@chromium.org

[commit-bot: I haz the power, 2016-01-28 21:37:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636453004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636453004/20001

[commit-bot: I haz the power, 2016-01-28 23:00:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 23:01:40]

Description was changed from

==========
Update Token Binding code to match latest draft draft-ietf-tokbind-protocol-04

BUG=467312
==========

to

==========
Update Token Binding code to match latest draft draft-ietf-tokbind-protocol-04

BUG=467312

Committed: https://crrev.com/47d408a4847886b442365a41ef8281ca99de0812
Cr-Commit-Position: refs/heads/master@{#372198}
==========

[commit-bot: I haz the power, 2016-01-28 23:01:41]

Patchset 2 (id:??) landed as
https://crrev.com/47d408a4847886b442365a41ef8281ca99de0812
Cr-Commit-Position: refs/heads/master@{#372198}