third_party/WebKit/Source/core/css/parser/CSSParserValues.cpp - Issue 1636453002: Use ASCII case-insensitive matching for ident-likes in the CSS parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserValues.cpp

Issue 1636453002: Use ASCII case-insensitive matching for ident-likes in the CSS parser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Consistent indentation in test. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserToken.h ('k') | third_party/WebKit/Source/core/css/parser/CSSParserValuesTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSParserValues.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserValues.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserValues.cpp

index 3aa4fe6b96b3a52a59d74cbc9ec60ed6b461a655..22d5adcc221243981b09d605660f22c3995937f5 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserValues.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserValues.cpp

@@ -46,7 +46,7 @@ CSSParserValueList::CSSParserValueList(CSSParserTokenRange range)

CSSParserValue value;

switch (token.type()) {

case FunctionToken: {

- if (token.valueEqualsIgnoringCase("url")) {

+ if (token.valueEqualsIgnoringASCIICase("url")) {

range.consume();

const CSSParserToken& next = range.consumeIncludingWhitespace();

if (next.type() == BadStringToken || range.consume().type() != RightParenthesisToken) {

@@ -59,7 +59,8 @@ CSSParserValueList::CSSParserValueList(CSSParserTokenRange range)

value.m_unit = CSSParserValue::URI;

value.string = next.value();

break;

- } else if (token.valueEqualsIgnoringCase("var")) {

+ }

+ if (token.valueEqualsIgnoringASCIICase("var")) {

destroyAndClear();

return;

}