third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp - Issue 1636453002: Use ASCII case-insensitive matching for ident-likes in the CSS parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

Issue 1636453002: Use ASCII case-insensitive matching for ident-likes in the CSS parser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/css-parser/ascii-case-insensitive-matching.html ('K') | « third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp b/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

index 4dd16c9a5bcad5ee9af34d06925b50b2b854434a..889607d0b24aa325f1647e7209ae3ef62727626f 100644

--- a/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp

@@ -105,7 +105,7 @@ bool SizesCalcParser::calcToReversePolishNotation(CSSParserTokenRange range)

return false;

break;

case FunctionToken:

- if (!token.valueEqualsIgnoringCase("calc"))

+ if (!token.valueEqualsIgnoringASCIICase("calc"))

return false;

// "calc(" is the same as "("

case LeftParenthesisToken: