third_party/WebKit/Source/core/css/parser/CSSSupportsParser.cpp - Issue 1636453002: Use ASCII case-insensitive matching for ident-likes in the CSS parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSSupportsParser.cpp

Issue 1636453002: Use ASCII case-insensitive matching for ident-likes in the CSS parser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/css-parser/ascii-case-insensitive-matching.html ('K') | « third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSSupportsParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSSupportsParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSSupportsParser.cpp

index 7764bff6d8ea36f70676e188c5a16e80a0a2a783..56ecaf2d1eab8ca865b5e518809000bc948ced4e 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSSupportsParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSSupportsParser.cpp

@@ -50,8 +50,8 @@ CSSSupportsParser::SupportsResult CSSSupportsParser::consumeCondition(CSSParserT

return Invalid;

if (clauseType == Unresolved)

clauseType = token.value().length() == 3 ? Conjunction : Disjunction;

- if ((clauseType == Conjunction && !equalIgnoringCase(token.value(), "and"))

- || (clauseType == Disjunction && !equalIgnoringCase(token.value(), "or")))

+ if ((clauseType == Conjunction && !token.valueEqualsIgnoringASCIICase("and"))

+ || (clauseType == Disjunction && !token.valueEqualsIgnoringASCIICase("or")))

return Invalid;

if (range.consumeIncludingWhitespace().type() != WhitespaceToken)

@@ -63,7 +63,7 @@ CSSSupportsParser::SupportsResult CSSSupportsParser::consumeCondition(CSSParserT

CSSSupportsParser::SupportsResult CSSSupportsParser::consumeNegation(CSSParserTokenRange range)

{

ASSERT(range.peek().type() == IdentToken);

- if (!equalIgnoringCase(range.consume().value(), "not"))

+ if (!range.consume().valueEqualsIgnoringASCIICase("not"))

return Invalid;

if (range.consumeIncludingWhitespace().type() != WhitespaceToken)

return Invalid;