Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1636443002: Move license to the top. (Closed)

Created:
4 years, 11 months ago by floitsch
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org, Johnni Winther, Brian Wilkerson
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M pkg/analyzer/lib/src/generated/generated/shared_messages.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/dart_messages/bin/publish.dart View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
4 years, 11 months ago (2016-01-25 15:30:13 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1636443002/diff/1/pkg/dart_messages/bin/publish.dart File pkg/dart_messages/bin/publish.dart (right): https://codereview.chromium.org/1636443002/diff/1/pkg/dart_messages/bin/publish.dart#newcode27 pkg/dart_messages/bin/publish.dart:27: // Copyright (c) 2015, the Dart project authors. ...
4 years, 11 months ago (2016-01-26 09:21:39 UTC) #3
floitsch
https://codereview.chromium.org/1636443002/diff/1/pkg/dart_messages/bin/publish.dart File pkg/dart_messages/bin/publish.dart (right): https://codereview.chromium.org/1636443002/diff/1/pkg/dart_messages/bin/publish.dart#newcode27 pkg/dart_messages/bin/publish.dart:27: // Copyright (c) 2015, the Dart project authors. Please ...
4 years, 11 months ago (2016-01-26 10:34:18 UTC) #4
floitsch
4 years, 11 months ago (2016-01-26 10:35:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
bbde44f7cc0b35f6d0551e48fd7d370c90ed8832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698