Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1636333003: Implement specced parsing algorithm for <area coords> (Closed)

Created:
4 years, 11 months ago by fs
Modified:
4 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement specced parsing algorithm for <area coords> This implements the parsing algorithm for "list of floating point numbers" and uses it to parse the 'coords' attribute on <area>. The fractional part of numbers are no longer discarded. The old parsing code in platform/Length.cpp is no longer used and is removed. BUG=578114 Committed: https://crrev.com/1d6711a6b110f354e90ee7a481323b54c7655b2d Cr-Commit-Position: refs/heads/master@{#371940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -131 lines) Patch
D third_party/WebKit/LayoutTests/fast/html/area-coords-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp View 4 chunks +61 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/Length.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/Length.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 11 months ago (2016-01-27 14:24:24 UTC) #2
tkent
lgtm
4 years, 11 months ago (2016-01-28 00:29:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636333003/1
4 years, 11 months ago (2016-01-28 00:29:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 00:39:27 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 00:41:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d6711a6b110f354e90ee7a481323b54c7655b2d
Cr-Commit-Position: refs/heads/master@{#371940}

Powered by Google App Engine
This is Rietveld 408576698