Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1636303002: PNaCl cleanup: Convert use of NaClGetTimeOfDayMicroseconds() (Closed)

Created:
4 years, 11 months ago by Mark Seaborn
Modified:
4 years, 11 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PNaCl cleanup: Convert most uses of NaClGetTimeOfDayMicroseconds() Use the timer interface from base/ instead. This removes a dependency on nacl_time.h from native_client/, which is #included indirectly in utility.h. I tested this manually by adding some logging to print the times, and I checked that they're roughly the same before and after the change when running NaClBrowserTestPnacl.PPAPICore (which tests PNaCl translation). BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832 TEST=see above Committed: https://crrev.com/3ae73738a61204d51728df4a0488d955a90b1797 Cr-Commit-Position: refs/heads/master@{#371823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M components/nacl/renderer/plugin/pnacl_coordinator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/nacl/renderer/plugin/pnacl_coordinator.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M components/nacl/renderer/plugin/pnacl_translate_thread.cc View 5 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636303002/1
4 years, 11 months ago (2016-01-27 05:05:25 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-27 05:49:55 UTC) #4
Mark Seaborn
4 years, 11 months ago (2016-01-27 16:39:26 UTC) #7
bbudge
lgtm
4 years, 11 months ago (2016-01-27 17:44:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636303002/1
4 years, 11 months ago (2016-01-27 18:03:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 18:12:35 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 18:13:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ae73738a61204d51728df4a0488d955a90b1797
Cr-Commit-Position: refs/heads/master@{#371823}

Powered by Google App Engine
This is Rietveld 408576698