runtime/bin/socket_patch.dart - Issue 16363005: Ensure that only byte values are sent by sockets and web sockets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_patch.dart

Issue 16363005: Ensure that only byte values are sent by sockets and web sockets (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixed a few bugs Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/socket_patch.dart

diff --git a/runtime/bin/socket_patch.dart b/runtime/bin/socket_patch.dart

index 7d0f5daf2c292d94c485d9b2b440a0b0a3a232b3..e69dfedbb752b5e8f33a6e3a6b2b26dbce05f838 100644

--- a/runtime/bin/socket_patch.dart

+++ b/runtime/bin/socket_patch.dart

@@ -299,7 +299,7 @@ class _NativeSocket extends NativeFieldWrapperClass1 {

if (isClosed) return 0;

if (bytes == 0) return 0;

_BufferAndStart bufferAndStart =

- _ensureFastAndSerializableBuffer(buffer, offset, offset + bytes);

+ _ensureFastAndSerializableByteData(buffer, offset, offset + bytes);

var result =

nativeWrite(bufferAndStart.buffer, bufferAndStart.start, bytes);

if (result is OSError) {

« no previous file with comments | « no previous file | sdk/lib/io/common.dart » ('j') | no next file with comments »