Ensure that only byte values are sent by sockets and web sockets

sdk/lib/io/common.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 // Constants used when working with native ports.
 // These must match the constants in runtime/bin/dartutils.h class CObject.
 const int _SUCCESS_RESPONSE = 0;
 const int _ILLEGAL_ARGUMENT_RESPONSE = 1;
@@ skipping 113 matching lines @@
     if (value is! int) {
       throw new ArgumentError("List element is not an integer at index $j");
     }
     newBuffer[i] = value;
     j++;
   }
   return new _BufferAndStart(newBuffer, 0);
 }
 
 
+_BufferAndStart _ensureFastAndSerializableByteBuffer(

[Anders Johnsen, 2013/06/12 06:13:58]

It's not a byte buffer but a view we returns, but maybe name it
_ensureFastAndSerializableTypedData?

[Søren Gjesse, 2013/06/12 08:34:00]

Done (just Data instead of TypedData).

+    List buffer, int start, int end) {
+  if (buffer is Uint8List) {
+    return new _BufferAndStart(buffer, start);
+  }
+  int length = end - start;
+  var newBuffer = new Uint8List(length);
+  int j = start;
+  for (int i = 0; i < length; i++) {
+    int value = buffer[j];
+    if (value is! int ||
+        value < 0 || 255 < value) {
+      throw new ArgumentError(
+          "List element is not a byte value (value $value at index $j)");
+    }
+    newBuffer[i] = value;
+    j++;
+  }
+  return new _BufferAndStart(newBuffer, 0);
+}
+
+
 // TODO(ager): The only reason for the class here is that
 // we cannot patch a top-level function.
 class _BufferUtils {
   // Check if a List is a builtin VM List type. Returns true
   // if the List is a builtin VM List type and false if it is
   // a user defined List type.
   external static bool _isBuiltinList(List buffer);
 }
 
 class _IOCrypto {
   external static Uint8List getRandomBytes(int count);
 }