Eat all keys involving Search when ChromeVox is on and add a pass through mode command.

Eat all keys involving Search when ChromeVox is on and add a pass through mode command.

In ChromeVox Next, Search+Shift+Esc activates pass through mode. The subsequent key will be passed through directly to the system. In particular, the key needs to be a ChromeVox command. For example, Search+Shift+Esc followed by any number of key (e.g. Ctrl+L), then ended by Search+L would result in the screen locking since the passed through key is the last ChromeVox command.

This cl also makes all key events involving Search captured.

TEST=hit Search+L. Verify the key gets eaten (no screen lock) and ChromeVox tries to move to the next link.
Press Search+Shift+Esc; then Search+L. Verify screen locks.
Do the same with sticky mode on. Double tap Search. Press Shift+Esc. Verify pass through activates. Press Search+L and see that screen locks.

Committed: https://crrev.com/f72134ae539a2f5547682e12881cf2fd35cf9efc
Cr-Commit-Position: refs/heads/master@{#372205}

[David Tseng, 2016-01-27 02:15:41]

Description was changed from

==========
Eat all keys involving Search when ChromeVox is on and add a pass through mode
command.
==========

to

==========
Eat all keys involving Search when ChromeVox is on and add a pass through mode
command.

In ChromeVox Next, Search+Shift+Esc activates pass through mode. The subsequent
key will be passed through directly to the system. In particular, the key needs
to be a ChromeVox command. For example, Search+Shift+Esc followed by any number
of key (e.g. Ctrl+L), then ended by Search+L would result in the screen locking
since the passed through key is the last ChromeVox command.

This cl also makes all key events involving Search captured.

TEST=hit Search+L. Verify the key gets eaten (no screen lock) and ChromeVox
tries to move to the next link.
Press Search+Shift+Esc; then Search+L. Verify screen locks.
Do the same with sticky mode on. Double tap Search. Press Shift+Esc. Verify pass
through activates. Press Search+L and see that screen locks.
==========

[David Tseng, 2016-01-27 02:15:41]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-01-27 05:27:52]

lgtm

This seems great, but is there any way to make it pass through just one complete
keystroke and not wait until the next ChromeVox command?

[David Tseng, 2016-01-27 19:57:20]

On 2016/01/27 05:27:52, dmazzoni wrote:
> lgtm
> 
> This seems great, but is there any way to make it pass through just one
complete
> keystroke and not wait until the next ChromeVox command?

Done (similar to the way I did it for Classic). Note that the key events behave
slightly differently than they would if it was in a real DOM. In particular,
calling stopPropagation inside of keydown doesn't cause it to skip the keyup
listener (so there's 3 keyups to consider rather than 2 keyups).

[dmazzoni, 2016-01-27 20:09:32]

lgtm

Great!

[David Tseng, 2016-01-28 23:09:33]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-01-28 23:10:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636243002/20001

[commit-bot: I haz the power, 2016-01-28 23:41:09]

Description was changed from

==========
Eat all keys involving Search when ChromeVox is on and add a pass through mode
command.

In ChromeVox Next, Search+Shift+Esc activates pass through mode. The subsequent
key will be passed through directly to the system. In particular, the key needs
to be a ChromeVox command. For example, Search+Shift+Esc followed by any number
of key (e.g. Ctrl+L), then ended by Search+L would result in the screen locking
since the passed through key is the last ChromeVox command.

This cl also makes all key events involving Search captured.

TEST=hit Search+L. Verify the key gets eaten (no screen lock) and ChromeVox
tries to move to the next link.
Press Search+Shift+Esc; then Search+L. Verify screen locks.
Do the same with sticky mode on. Double tap Search. Press Shift+Esc. Verify pass
through activates. Press Search+L and see that screen locks.
==========

to

==========
Eat all keys involving Search when ChromeVox is on and add a pass through mode
command.

In ChromeVox Next, Search+Shift+Esc activates pass through mode. The subsequent
key will be passed through directly to the system. In particular, the key needs
to be a ChromeVox command. For example, Search+Shift+Esc followed by any number
of key (e.g. Ctrl+L), then ended by Search+L would result in the screen locking
since the passed through key is the last ChromeVox command.

This cl also makes all key events involving Search captured.

TEST=hit Search+L. Verify the key gets eaten (no screen lock) and ChromeVox
tries to move to the next link.
Press Search+Shift+Esc; then Search+L. Verify screen locks.
Do the same with sticky mode on. Double tap Search. Press Shift+Esc. Verify pass
through activates. Press Search+L and see that screen locks.
==========

[commit-bot: I haz the power, 2016-01-28 23:41:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 23:42:49]

Description was changed from

==========
Eat all keys involving Search when ChromeVox is on and add a pass through mode
command.

In ChromeVox Next, Search+Shift+Esc activates pass through mode. The subsequent
key will be passed through directly to the system. In particular, the key needs
to be a ChromeVox command. For example, Search+Shift+Esc followed by any number
of key (e.g. Ctrl+L), then ended by Search+L would result in the screen locking
since the passed through key is the last ChromeVox command.

This cl also makes all key events involving Search captured.

TEST=hit Search+L. Verify the key gets eaten (no screen lock) and ChromeVox
tries to move to the next link.
Press Search+Shift+Esc; then Search+L. Verify screen locks.
Do the same with sticky mode on. Double tap Search. Press Shift+Esc. Verify pass
through activates. Press Search+L and see that screen locks.
==========

to

==========
Eat all keys involving Search when ChromeVox is on and add a pass through mode
command.

In ChromeVox Next, Search+Shift+Esc activates pass through mode. The subsequent
key will be passed through directly to the system. In particular, the key needs
to be a ChromeVox command. For example, Search+Shift+Esc followed by any number
of key (e.g. Ctrl+L), then ended by Search+L would result in the screen locking
since the passed through key is the last ChromeVox command.

This cl also makes all key events involving Search captured.

TEST=hit Search+L. Verify the key gets eaten (no screen lock) and ChromeVox
tries to move to the next link.
Press Search+Shift+Esc; then Search+L. Verify screen locks.
Do the same with sticky mode on. Double tap Search. Press Shift+Esc. Verify pass
through activates. Press Search+L and see that screen locks.

Committed: https://crrev.com/f72134ae539a2f5547682e12881cf2fd35cf9efc
Cr-Commit-Position: refs/heads/master@{#372205}
==========

[commit-bot: I haz the power, 2016-01-28 23:42:50]

Patchset 2 (id:??) landed as
https://crrev.com/f72134ae539a2f5547682e12881cf2fd35cf9efc
Cr-Commit-Position: refs/heads/master@{#372205}