Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Unified Diff: test/codegen/expect/fieldtest.js

Issue 1636233002: fixes #427, static fields emitted outside the scope of their class (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/codegen/expect/fieldtest.js
diff --git a/test/codegen/expect/fieldtest.js b/test/codegen/expect/fieldtest.js
index c8b14863cee4391f70e38a26c0194b206eda56c7..fb8ea97668cce861d178f6eb9669e924bbe914cb 100644
--- a/test/codegen/expect/fieldtest.js
+++ b/test/codegen/expect/fieldtest.js
@@ -78,20 +78,36 @@ dart_library.library('fieldtest', null, /* Imports */[
dart.setSignature(Generic, {
methods: () => ({foo: [dart.dynamic, [T]]})
});
+ Generic.bar = 'hello';
return Generic;
});
let Generic = Generic$();
- Generic.bar = 'hello';
class StaticFieldOrder1 extends core.Object {}
StaticFieldOrder1.d = 4;
- StaticFieldOrder1.c = dart.notNull(StaticFieldOrder1.d) + 2;
- StaticFieldOrder1.b = dart.notNull(StaticFieldOrder1.c) + 3;
- StaticFieldOrder1.a = dart.notNull(StaticFieldOrder1.b) + 1;
+ dart.defineLazyProperties(StaticFieldOrder1, {
+ get a() {
+ return dart.notNull(StaticFieldOrder1.b) + 1;
+ },
+ get c() {
+ return dart.notNull(StaticFieldOrder1.d) + 2;
+ },
+ get b() {
+ return dart.notNull(StaticFieldOrder1.c) + 3;
+ }
+ });
class StaticFieldOrder2 extends core.Object {}
StaticFieldOrder2.d = 4;
- StaticFieldOrder2.c = dart.notNull(StaticFieldOrder2.d) + 2;
- StaticFieldOrder2.b = dart.notNull(StaticFieldOrder2.c) + 3;
- StaticFieldOrder2.a = dart.notNull(StaticFieldOrder2.b) + 1;
+ dart.defineLazyProperties(StaticFieldOrder2, {
+ get a() {
+ return dart.notNull(StaticFieldOrder2.b) + 1;
+ },
+ get c() {
+ return dart.notNull(StaticFieldOrder2.d) + 2;
+ },
+ get b() {
+ return dart.notNull(StaticFieldOrder2.c) + 3;
+ }
+ });
class MyEnum extends core.Object {
MyEnum(index) {
this.index = index;

Powered by Google App Engine
This is Rietveld 408576698