Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 163623002: Comparison in effect context lazy deopt fix. (Closed)

Created:
6 years, 10 months ago by Jarin
Modified:
6 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Comparison in effect context lazy deopt fix. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19396

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -36 lines) Patch
M src/hydrogen.h View 1 chunk +16 lines, -12 lines 0 comments Download
M src/hydrogen.cc View 1 5 chunks +17 lines, -9 lines 0 comments Download
A + test/mjsunit/regress/comparison-in-effect-context-deopt.js View 1 chunk +13 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 10 months ago (2014-02-13 14:19:11 UTC) #1
Jakob Kummerow
lgtm https://codereview.chromium.org/163623002/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/163623002/diff/1/src/hydrogen.cc#newcode9616 src/hydrogen.cc:9616: if (push_sim_result == NO_PUSH_BEFORE_SIMULATE) { nit: I'd find ...
6 years, 10 months ago (2014-02-13 15:55:32 UTC) #2
Jarin
6 years, 10 months ago (2014-02-16 05:51:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19396 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698