Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Side by Side Diff: third_party/WebKit/Source/core/inspector/InjectedScript.h

Issue 1636223002: DevTools: remove ScriptState/Value from the InjectedScript APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 void setVariableValue(ErrorString*, v8::Local<v8::Object> callFrames, const String* callFrameIdOpt, const String* functionObjectIdOpt, int scopeNumber, cons t String& variableName, const String& newValueStr); 95 void setVariableValue(ErrorString*, v8::Local<v8::Object> callFrames, const String* callFrameIdOpt, const String* functionObjectIdOpt, int scopeNumber, cons t String& variableName, const String& newValueStr);
96 void getFunctionDetails(ErrorString*, const String& functionId, RefPtr<TypeB uilder::Debugger::FunctionDetails>* result); 96 void getFunctionDetails(ErrorString*, const String& functionId, RefPtr<TypeB uilder::Debugger::FunctionDetails>* result);
97 void getGeneratorObjectDetails(ErrorString*, const String& functionId, RefPt r<TypeBuilder::Debugger::GeneratorObjectDetails>* result); 97 void getGeneratorObjectDetails(ErrorString*, const String& functionId, RefPt r<TypeBuilder::Debugger::GeneratorObjectDetails>* result);
98 void getCollectionEntries(ErrorString*, const String& objectId, RefPtr<TypeB uilder::Array<TypeBuilder::Debugger::CollectionEntry> >* result); 98 void getCollectionEntries(ErrorString*, const String& objectId, RefPtr<TypeB uilder::Array<TypeBuilder::Debugger::CollectionEntry> >* result);
99 void getProperties(ErrorString*, const String& objectId, bool ownProperties, bool accessorPropertiesOnly, bool generatePreview, RefPtr<TypeBuilder::Array<Ty peBuilder::Runtime::PropertyDescriptor>>* result, RefPtr<TypeBuilder::Debugger:: ExceptionDetails>*); 99 void getProperties(ErrorString*, const String& objectId, bool ownProperties, bool accessorPropertiesOnly, bool generatePreview, RefPtr<TypeBuilder::Array<Ty peBuilder::Runtime::PropertyDescriptor>>* result, RefPtr<TypeBuilder::Debugger:: ExceptionDetails>*);
100 void getInternalProperties(ErrorString*, const String& objectId, RefPtr<Type Builder::Array<TypeBuilder::Runtime::InternalPropertyDescriptor>>* result, RefPt r<TypeBuilder::Debugger::ExceptionDetails>*); 100 void getInternalProperties(ErrorString*, const String& objectId, RefPtr<Type Builder::Array<TypeBuilder::Runtime::InternalPropertyDescriptor>>* result, RefPt r<TypeBuilder::Debugger::ExceptionDetails>*);
101 void releaseObject(const String& objectId); 101 void releaseObject(const String& objectId);
102 102
103 PassRefPtr<TypeBuilder::Array<TypeBuilder::Debugger::CallFrame>> wrapCallFra mes(v8::Local<v8::Object>, int asyncOrdinal); 103 PassRefPtr<TypeBuilder::Array<TypeBuilder::Debugger::CallFrame>> wrapCallFra mes(v8::Local<v8::Object>, int asyncOrdinal);
104 104
105 PassRefPtr<TypeBuilder::Runtime::RemoteObject> wrapObject(const ScriptValue& , const String& groupName, bool generatePreview = false) const; 105 PassRefPtr<TypeBuilder::Runtime::RemoteObject> wrapObject(v8::Local<v8::Valu e>, const String& groupName, bool generatePreview = false) const;
106 PassRefPtr<TypeBuilder::Runtime::RemoteObject> wrapTable(const ScriptValue& table, const ScriptValue& columns) const; 106 PassRefPtr<TypeBuilder::Runtime::RemoteObject> wrapTable(v8::Local<v8::Value > table, v8::Local<v8::Value> columns) const;
107 v8::Local<v8::Value> findObject(const RemoteObjectId&) const; 107 v8::Local<v8::Value> findObject(const RemoteObjectId&) const;
108 108
109 String objectIdToObjectGroupName(const String& objectId) const; 109 String objectIdToObjectGroupName(const String& objectId) const;
110 void releaseObjectGroup(const String&); 110 void releaseObjectGroup(const String&);
111 111
112 void setCustomObjectFormatterEnabled(bool); 112 void setCustomObjectFormatterEnabled(bool);
113 int contextId() { return m_contextId; } 113 int contextId() { return m_contextId; }
114 114
115 private: 115 private:
116 friend InjectedScript* InjectedScriptManager::injectedScriptFor(ScriptState* ); 116 friend InjectedScript* InjectedScriptManager::injectedScriptFor(v8::Local<v8 ::Context>);
117 InjectedScript(ScriptValue, V8DebuggerClient*, PassRefPtr<InjectedScriptNati ve>, int contextId); 117 InjectedScript(v8::Local<v8::Object>, V8DebuggerClient*, PassRefPtr<Injected ScriptNative>, int contextId);
118 118
119 bool canAccessInspectedWindow() const; 119 bool canAccessInspectedWindow() const;
120 v8::Local<v8::Context> v8Context() const; 120 v8::Local<v8::Context> v8Context() const;
121 v8::Local<v8::Value> v8Value() const; 121 v8::Local<v8::Value> v8Value() const;
122 v8::Local<v8::Value> callFunctionWithEvalEnabled(ScriptFunctionCall&, bool& hadException) const; 122 v8::Local<v8::Value> callFunctionWithEvalEnabled(ScriptFunctionCall&, bool& hadException) const;
123 void makeCall(ScriptFunctionCall&, RefPtr<JSONValue>* result); 123 void makeCall(ScriptFunctionCall&, RefPtr<JSONValue>* result);
124 void makeEvalCall(ErrorString*, ScriptFunctionCall&, RefPtr<TypeBuilder::Run time::RemoteObject>* result, TypeBuilder::OptOutput<bool>* wasThrown, RefPtr<Typ eBuilder::Debugger::ExceptionDetails>* = 0); 124 void makeEvalCall(ErrorString*, ScriptFunctionCall&, RefPtr<TypeBuilder::Run time::RemoteObject>* result, TypeBuilder::OptOutput<bool>* wasThrown, RefPtr<Typ eBuilder::Debugger::ExceptionDetails>* = 0);
125 void makeCallWithExceptionDetails(ScriptFunctionCall&, RefPtr<JSONValue>* re sult, RefPtr<TypeBuilder::Debugger::ExceptionDetails>*); 125 void makeCallWithExceptionDetails(ScriptFunctionCall&, RefPtr<JSONValue>* re sult, RefPtr<TypeBuilder::Debugger::ExceptionDetails>*);
126 126
127 v8::Isolate* m_isolate; 127 v8::Isolate* m_isolate;
128 ScriptValue m_injectedScriptObject; 128 ScriptValue m_injectedScriptObject;
129 V8DebuggerClient* m_client; 129 V8DebuggerClient* m_client;
130 RefPtr<InjectedScriptNative> m_native; 130 RefPtr<InjectedScriptNative> m_native;
131 int m_contextId; 131 int m_contextId;
132 }; 132 };
133 133
134 } // namespace blink 134 } // namespace blink
135 135
136 #endif 136 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698