Give user ability to file a feedback report from the display error notification.

ash/display/display_error_observer_chromeos.cc

Index: ash/display/display_error_observer_chromeos.cc
diff --git a/ash/display/display_error_observer_chromeos.cc b/ash/display/display_error_observer_chromeos.cc
index c08e6402da45394b01d650ecc0de98a094d06851..7a11b6dcae031f11c8aa29bbda8b4adb25b1fa50 100644
--- a/ash/display/display_error_observer_chromeos.cc
+++ b/ash/display/display_error_observer_chromeos.cc
@@ -4,9 +4,13 @@
 
 #include "ash/display/display_error_observer_chromeos.h"
 
+#include <cinttypes>
 #include <utility>
 
+#include "ash/new_window_delegate.h"
+#include "ash/shell.h"
 #include "ash/system/system_notifier.h"
+#include "base/strings/string_number_conversions.h"
 #include "grit/ash_resources.h"
 #include "grit/ash_strings.h"
 #include "ui/base/l10n/l10n_util.h"
@@ -23,6 +27,27 @@ namespace {
 
 const char kDisplayErrorNotificationId[] = "chrome://settings/display/error";
 
+// A notification delegate that will start the feedback app when the notication
+// is clicked.
+class DisplayErrorNotificationDelegate
+    : public message_center::NotificationDelegate {
+ public:
+  DisplayErrorNotificationDelegate() = default;
+
+  // message_center::NotificationDelegate:
+  bool HasClickedListener() override { return true; }
+
+  void Click() override {
+    ash::Shell::GetInstance()->new_window_delegate()->OpenFeedbackPage();
+  }
+
+ private:
+  // Private destructor since NotificationDelegate is ref-counted.
+  ~DisplayErrorNotificationDelegate() override = default;
+
+  DISALLOW_COPY_AND_ASSIGN(DisplayErrorNotificationDelegate);
+};
+
 }  // namespace
 
 DisplayErrorObserver::DisplayErrorObserver() {
@@ -34,6 +59,14 @@ DisplayErrorObserver::~DisplayErrorObserver() {
 void DisplayErrorObserver::OnDisplayModeChangeFailed(
     const ui::DisplayConfigurator::DisplayStateList& displays,
     ui::MultipleDisplayState new_state) {
+  LOG(ERROR) << "Failed to configure the following display(s):";
+  for (const auto& display : displays) {
+    LOG(ERROR) << "- Display with ID = " << display->display_id()
+               << ", and EDID = " << base::HexEncode(display->edid().data(),
+                                                     display->edid().size())
+               << ".";
+  }
+
   // Always remove the notification to make sure the notification appears
   // as a popup in any situation.
   message_center::MessageCenter::Get()->RemoveNotification(
@@ -53,7 +86,8 @@ void DisplayErrorObserver::OnDisplayModeChangeFailed(
       GURL(),
       message_center::NotifierId(message_center::NotifierId::SYSTEM_COMPONENT,
                                  system_notifier::kNotifierDisplayError),
-      message_center::RichNotificationData(), NULL));
+      message_center::RichNotificationData(),
+      new DisplayErrorNotificationDelegate));
   message_center::MessageCenter::Get()->AddNotification(
       std::move(notification));
 }