Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: ui/display/types/display_snapshot.cc

Issue 1636153002: Give user ability to file a feedback report from the display error notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: oshima's comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/display/types/display_snapshot.h ('k') | ui/display/util/x11/edid_parser_x11.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/display/types/display_snapshot.h" 5 #include "ui/display/types/display_snapshot.h"
6 6
7 namespace ui { 7 namespace ui {
8 8
9 DisplaySnapshot::DisplaySnapshot(int64_t display_id, 9 DisplaySnapshot::DisplaySnapshot(int64_t display_id,
10 const gfx::Point& origin, 10 const gfx::Point& origin,
11 const gfx::Size& physical_size, 11 const gfx::Size& physical_size,
12 DisplayConnectionType type, 12 DisplayConnectionType type,
13 bool is_aspect_preserving_scaling, 13 bool is_aspect_preserving_scaling,
14 bool has_overscan, 14 bool has_overscan,
15 std::string display_name, 15 std::string display_name,
16 const base::FilePath& sys_path, 16 const base::FilePath& sys_path,
17 const std::vector<const DisplayMode*>& modes, 17 const std::vector<const DisplayMode*>& modes,
18 const std::vector<uint8_t>& edid,
18 const DisplayMode* current_mode, 19 const DisplayMode* current_mode,
19 const DisplayMode* native_mode) 20 const DisplayMode* native_mode)
20 : display_id_(display_id), 21 : display_id_(display_id),
21 origin_(origin), 22 origin_(origin),
22 physical_size_(physical_size), 23 physical_size_(physical_size),
23 type_(type), 24 type_(type),
24 is_aspect_preserving_scaling_(is_aspect_preserving_scaling), 25 is_aspect_preserving_scaling_(is_aspect_preserving_scaling),
25 has_overscan_(has_overscan), 26 has_overscan_(has_overscan),
26 display_name_(display_name), 27 display_name_(display_name),
27 sys_path_(sys_path), 28 sys_path_(sys_path),
28 modes_(modes), 29 modes_(modes),
30 edid_(edid),
29 current_mode_(current_mode), 31 current_mode_(current_mode),
30 native_mode_(native_mode), 32 native_mode_(native_mode),
31 product_id_(kInvalidProductID) {} 33 product_id_(kInvalidProductID) {
34 if (edid_.size() == 128U) {
dnicoara 2016/02/02 20:43:50 You must handle the case when the size isn't 128.
afakhry 2016/02/05 16:47:52 Done.
35 // We must explicitly clear out the bytes that represent the serial number.
36 // bytes 12-15.
37 for (int i = 12; i <= 15; ++i)
oshima 2016/02/02 20:27:17 define const for the position and length, with ref
afakhry 2016/02/05 16:47:52 Done.
38 edid_[i] = 0;
39 }
40 }
32 41
33 DisplaySnapshot::~DisplaySnapshot() {} 42 DisplaySnapshot::~DisplaySnapshot() {}
34 43
35 } // namespace ui 44 } // namespace ui
OLDNEW
« no previous file with comments | « ui/display/types/display_snapshot.h ('k') | ui/display/util/x11/edid_parser_x11.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698