Issue 163613012: Revert 251442 "Migrate old Shortcuts DB data to conform to new t..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 163613012: Revert 251442 "Migrate old Shortcuts DB data to conform to new t..." (Closed)

Created:
6 years, 10 months ago by Yaron

Modified:
6 years, 10 months ago

Reviewers:
Anuj

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 251442 "Migrate old Shortcuts DB data to conform to new t..." Broke tests: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/18614/steps/unit_tests/logs/stdio#failure4 > Migrate old Shortcuts DB data to conform to new type values > > All new suggestion types will be a Google Search URL with https. In some cases, > url may contain additional identifying parameter. > > BUG=339270 > TBR=brettw@chromium.org > > Review URL: https://codereview.chromium.org/134853004 TBR=skanuj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251473

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -75 lines)			Patch
M	trunk/src/chrome/browser/history/history_database.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/history/shortcuts_database.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/history/shortcuts_database.cc	View	3 chunks	+3 lines, -31 lines	0 comments	Download
M	trunk/src/chrome/browser/history/shortcuts_database_unittest.cc	View	2 chunks	+3 lines, -31 lines	0 comments	Download
D	trunk/src/chrome/test/data/History/Shortcuts.v0.sql	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 2 (0 generated)

Yaron

6 years, 10 months ago (2014-02-15 01:38:01 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r251473 (tree was closed).