Issue 163613006: Revert 251178 "Trace event micro-optimization: use finer grained..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 163613006: Revert 251178 "Trace event micro-optimization: use finer grained..." (Closed)

Created:
6 years, 10 months ago by Derek Bruening

Modified:
6 years, 10 months ago

Reviewers:
bulach

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 251178 "Trace event micro-optimization: use finer grained..." due to data races raised on the tsan v2 bot. BUG=343802 > Trace event micro-optimization: use finer grained lock. > > GetCategoryGroupEnabledInternal is a hotspot. > It traverses an append-only list, so it's safe to use a finer-grained lock, > and avoid it altogether for the "fast path", i.e., when the category is > already known. > > BUG= > > Review URL: https://codereview.chromium.org/144423009 TBR=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251262

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -39 lines)			Patch
	M	trunk/src/base/debug/trace_event_impl.cc	View		2 chunks	+27 lines, -39 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Derek Bruening

6 years, 10 months ago (2014-02-14 05:34:56 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r251262 (tree was closed).

Expand Messages | Collapse Messages