Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 163613003: Disable FirstRunMasterPrefsWithTrackedPreferences.TrackedPreferencesSurviveFirstRun on Linux on off… (Closed)

Created:
6 years, 10 months ago by pshenoy
Modified:
6 years, 10 months ago
Reviewers:
gab
CC:
chromium-reviews, anantha
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable FirstRunMasterPrefsWithTrackedPreferences.TrackedPreferencesSurviveFirstRun on Linux on official builder. See below issues for details. http://crbug.com/342427 http://crbug.com/314221 BUG=342427, 314221 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251526

Patch Set 1 #

Total comments: 2

Patch Set 2 : Disable import related tests too on Linux. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/first_run/first_run_browsertest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pshenoy
6 years, 10 months ago (2014-02-13 21:24:42 UTC) #1
gab
https://codereview.chromium.org/163613003/diff/1/chrome/browser/first_run/first_run_browsertest.cc File chrome/browser/first_run/first_run_browsertest.cc (right): https://codereview.chromium.org/163613003/diff/1/chrome/browser/first_run/first_run_browsertest.cc#newcode221 chrome/browser/first_run/first_run_browsertest.cc:221: #if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX) Don't these import tests also ...
6 years, 10 months ago (2014-02-14 21:27:46 UTC) #2
pshenoy
https://codereview.chromium.org/163613003/diff/1/chrome/browser/first_run/first_run_browsertest.cc File chrome/browser/first_run/first_run_browsertest.cc (right): https://codereview.chromium.org/163613003/diff/1/chrome/browser/first_run/first_run_browsertest.cc#newcode221 chrome/browser/first_run/first_run_browsertest.cc:221: #if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX) On 2014/02/14 21:27:47, gab wrote: ...
6 years, 10 months ago (2014-02-14 21:35:57 UTC) #3
gab
lgtm, thanks! PS: Someone should look into why these hang on Linux/Mac... it's not clearly ...
6 years, 10 months ago (2014-02-14 21:37:17 UTC) #4
pshenoy
The CQ bit was checked by pshenoy@chromium.org
6 years, 10 months ago (2014-02-14 21:38:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/163613003/90001
6 years, 10 months ago (2014-02-14 21:42:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 23:06:31 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264647
6 years, 10 months ago (2014-02-14 23:06:35 UTC) #8
pshenoy
The CQ bit was checked by pshenoy@chromium.org
6 years, 10 months ago (2014-02-14 23:07:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/163613003/90001
6 years, 10 months ago (2014-02-14 23:22:28 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 05:04:38 UTC) #11
Message was sent while issue was closed. 
Change committed as 251526

Powered by Google App Engine
This is Rietveld 408576698