Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1636123002: Expose ycbcr_420v_image extension via capabilities. (Closed)

Created:
4 years, 11 months ago by Daniele Castagna
Modified:
4 years, 11 months ago
Reviewers:
reveman, no sievers, dcheng
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose ycbcr_420v_image extension via capabilities. This CL adds a flag in GPU capabilities that represents if the extension CHROMIUM_ycbcr_420v_image is available. BUG=524582 Committed: https://crrev.com/44c85a51c3fab4ddcdef2b10646b7f14697206c4 Cr-Commit-Position: refs/heads/master@{#371925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M gpu/command_buffer/common/capabilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/capabilities.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/gpu_command_buffer_traits_multi.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Daniele Castagna
4 years, 11 months ago (2016-01-26 20:57:52 UTC) #2
reveman
lgtm
4 years, 11 months ago (2016-01-26 21:12:12 UTC) #3
Daniele Castagna
+sievers for gpu/command_buffer. +dcheng for security review.
4 years, 11 months ago (2016-01-26 21:19:09 UTC) #5
dcheng
Just curious: how will this flag be used? the ipc changes itself seem fine, but ...
4 years, 11 months ago (2016-01-26 21:20:23 UTC) #6
Daniele Castagna
On 2016/01/26 at 21:20:23, dcheng wrote: > Just curious: how will this flag be used? ...
4 years, 11 months ago (2016-01-26 21:49:42 UTC) #7
no sievers
lgtm
4 years, 11 months ago (2016-01-26 22:05:00 UTC) #8
dcheng
lgtm
4 years, 11 months ago (2016-01-27 22:17:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636123002/1
4 years, 11 months ago (2016-01-27 22:25:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 00:20:58 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/44c85a51c3fab4ddcdef2b10646b7f14697206c4 Cr-Commit-Position: refs/heads/master@{#371925}
4 years, 11 months ago (2016-01-28 00:23:19 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 00:23:38 UTC) #15
Message was sent while issue was closed.
Failed to apply the patch.

Powered by Google App Engine
This is Rietveld 408576698