H264 HW encode using VideoToolbox

content/common/gpu/media/video_encode_accelerator_unittest.cc

Index: content/common/gpu/media/video_encode_accelerator_unittest.cc
diff --git a/content/common/gpu/media/video_encode_accelerator_unittest.cc b/content/common/gpu/media/video_encode_accelerator_unittest.cc
index 9224e89c72f9f2d34691ff5904428e7a75507b9a..4b0943f03e9146dbc1bf369d478353bd515eb2d9 100644
--- a/content/common/gpu/media/video_encode_accelerator_unittest.cc
+++ b/content/common/gpu/media/video_encode_accelerator_unittest.cc
@@ -55,6 +55,8 @@
 // Status has been defined as int in Xlib.h.
 #undef Status
 #endif  // defined(ARCH_CPU_X86_FAMILY)
+#elif defined(OS_MACOSX)
+#include "content/common/gpu/media/vt_video_encode_accelerator_mac.h"
 #else
 #error The VideoEncodeAcceleratorUnittest is not supported on this platform.
 #endif
@@ -126,7 +128,11 @@ const unsigned int kLoggedLatencyPercentiles[] = {50, 75, 95};
 //                                    of the stream.
 //   Bitrate is only forced for tests that test bitrate.
 const char* g_default_in_filename = "bear_320x192_40frames.yuv";
+#if !defined(OS_MACOSX)
 const char* g_default_in_parameters = ":320:192:1:out.h264:200000";
+#else
+const char* g_default_in_parameters = ":320:192:0:out.h264:200000";
+#endif
 
 // Enabled by including a --fake_encoder flag to the command line invoking the
 // test.
@@ -810,6 +816,7 @@ class VEAClient : public VideoEncodeAccelerator::Client {
   scoped_ptr<media::VideoEncodeAccelerator> CreateFakeVEA();
   scoped_ptr<media::VideoEncodeAccelerator> CreateV4L2VEA();
   scoped_ptr<media::VideoEncodeAccelerator> CreateVaapiVEA();
+  scoped_ptr<media::VideoEncodeAccelerator> CreateVTVEA();
 
   void SetState(ClientState new_state);
 
@@ -1071,6 +1078,14 @@ scoped_ptr<media::VideoEncodeAccelerator> VEAClient::CreateVaapiVEA() {
   return encoder;
 }
 
+scoped_ptr<media::VideoEncodeAccelerator> VEAClient::CreateVTVEA() {
+  scoped_ptr<media::VideoEncodeAccelerator> encoder;
+#if defined(OS_MACOSX)
+  encoder.reset(new VTVideoEncodeAccelerator());
+#endif
+  return encoder;
+}
+
 void VEAClient::CreateEncoder() {
   DCHECK(thread_checker_.CalledOnValidThread());
   LOG_ASSERT(!has_encoder());
@@ -1078,7 +1093,8 @@ void VEAClient::CreateEncoder() {
   scoped_ptr<media::VideoEncodeAccelerator> encoders[] = {
     CreateFakeVEA(),
     CreateV4L2VEA(),
-    CreateVaapiVEA()
+    CreateVaapiVEA(),
+    CreateVTVEA()
   };
 
   DVLOG(1) << "Profile: " << test_stream_->requested_profile
@@ -1649,6 +1665,7 @@ TEST_P(VideoEncodeAcceleratorTest, TestSimpleEncode) {
   encoder_thread.Stop();
 }
 
+#if !defined(OS_MACOSX)
 INSTANTIATE_TEST_CASE_P(
     SimpleEncode,
     VideoEncodeAcceleratorTest,
@@ -1693,6 +1710,25 @@ INSTANTIATE_TEST_CASE_P(
         base::MakeTuple(3, false, 0, false, false, false, false, false),
         base::MakeTuple(3, false, 0, true, false, false, true, false),
         base::MakeTuple(3, false, 0, true, false, true, false, false)));
+#else
+INSTANTIATE_TEST_CASE_P(

[miu, 2016/02/10 21:04:56]

BTW--Will these tests run in the waterfall?  IIRC, this module's tests are
currently only configured to run on ChromeOS bots.

[emircan, 2016/02/11 09:22:09]

I changed content/content_tests.gypi	to build this test for mac as well. Would
it be picked up as a target? If not, how should I add it to waterfall?

[miu, 2016/02/11 21:09:40]

I'm not sure about this one.  I think it has dependencies on downloading videos
from external sources.  Pawel would know.

[Pawel Osciak, 2016/02/18 11:16:14]

We have a short raw stream in Chromium tree that can be used for basic sanity
testing: media/test/data/bear_320x192_40frames.yuv, but it's not good for
bitrate tests. It's already here in the code at the top of this file
(g_default_in_filename).

So if you run this test as is on the bots, the
"media::GetTestDataFilePath(content::g_default_in_filename)" line below will
pick it up automagically.

Locally you have to make sure
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/test_da...
resolves to where the file is (using DIR_SOURCE_ROOT for example).

+    SimpleEncode,
+    VideoEncodeAcceleratorTest,
+    ::testing::Values(
+        base::MakeTuple(1, true, 0, false, false, false, false, false)));
+
+INSTANTIATE_TEST_CASE_P(
+    EncoderPerf,
+    VideoEncodeAcceleratorTest,
+    ::testing::Values(
+        base::MakeTuple(1, false, 0, false, true, false, false, false)));
+
+INSTANTIATE_TEST_CASE_P(
+    MultipleEncoders,
+    VideoEncodeAcceleratorTest,
+    ::testing::Values(
+        base::MakeTuple(3, false, 0, false, false, false, false, false)));
+#endif
 
 // TODO(posciak): more tests:
 // - async FeedEncoderWithOutput