H264 HW encode using VideoToolbox

content/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//content/common/common.gni")
 import("//media/media_options.gni")
 import("//mojo/public/tools/bindings/mojom.gni")
 if (is_mac) {
@@ skipping 216 matching lines @@
 
   if (is_mac) {
     sources += [
                  "gpu/client/gpu_memory_buffer_impl_io_surface.cc",
                  "gpu/client/gpu_memory_buffer_impl_io_surface.h",
                  "gpu/gpu_memory_buffer_factory_io_surface.cc",
                  "gpu/gpu_memory_buffer_factory_io_surface.h",
                  "gpu/media/vt_mac.h",
                  "gpu/media/vt_video_decode_accelerator_mac.cc",
                  "gpu/media/vt_video_decode_accelerator_mac.h",
+                 "gpu/media/vt_video_encode_accelerator.cc",
+                 "gpu/media/vt_video_encode_accelerator.h",

[hbos_chromium, 2016/02/03 18:21:08]

Is there a reason the decoder accelerator is named "_mac" and the encoder isn't?

[emircan, 2016/02/04 05:18:51]

I realize there are some inconsistency in this, and unfortunately I couldn't
find a straight answer from style guides.
But looking over this folder, vt_video_decode_accelerator_mac and
dxva_video_decode_accelerator_win has platform suffixes. Although it is CrOS
specific, v4l2_video_decode_accelerator doesn't have a suffix.
android_video_decode_accelerator is a prefix. The ideal solution would be to
have platform folders in this directory and remove all platform suffix/prefixs
from the names. So I decided to go in that direction as I am planning to touch
more files in this directory soon, but I am open to suggestions as well.

                ] + get_target_outputs(":libvt_generate_stubs")
 
     sources -= [ "plugin_list_posix.cc" ]
 
     deps += [
       ":libvt_generate_stubs",
       "//content:resources",
       "//content/app/resources",
       "//third_party/WebKit/public:image_resources",
       "//third_party/WebKit/public:resources",
@@ skipping 304 matching lines @@
   import_dirs = [ "//mojo/services" ]
 
   deps = [
     "//components/mus/public/interfaces",
     "//content/public/common:mojo_bindings",
     "//mojo/shell/public/interfaces",
     "//skia/public/interfaces",
     "//ui/mojo/geometry:interfaces",
   ]
 }