H264 HW encode using VideoToolbox

chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <cmath>
 #include <vector>
@@ skipping 308 matching lines @@
 }  // namespace
 
 class CastStreamingApiTestWithPixelOutput : public CastStreamingApiTest {
   void SetUp() override {
     EnablePixelOutput();
     CastStreamingApiTest::SetUp();
   }
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     command_line->AppendSwitchASCII(::switches::kWindowSize, "128,128");
+#if defined(OS_MACOSX)
+    command_line->AppendSwitch(::switches::kDisableVTAcceleratedVideoEncode);

[miu, 2016/03/09 01:48:50]

Is this still needed?  If the tests now work, let's take this out and also take
out the command-line switch.

[emircan, 2016/03/09 02:26:03]

Unfortunately it is still needed. In my local tests, I am able to create a VT HW
session, so H264 gets reported and this code triggers Cast's H264 implementation
which fails. 

[miu, 2016/03/09 03:03:19]

Ok, I think this may be the problem:
https://code.google.com/p/chromium/codesearch#chromium/src/media/cast/receive...

In other words, this test is creating a Cast Receiver, but our Chromium
implementation lacks H264 decode support.  In that case, what you should do is
force VP8 to be used:

1. Modify the sender JavaScript part of this test code to use VP8 instead of
H264 (which became the default, because of your change).  Relevant code is here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/e...

Just set videoParams.payload.codecName = 'VP8' before start() is called a few
lines later.  This will force the VP8 encoder to be used instead.

2. Remove this command-line override.

3. Confirm the test runs now.  :-)

[emircan, 2016/03/09 04:04:45]

Thank you very much. Now, cast test works as expected and I am removing the flag
:)

+#endif  // defined(OS_MACOSX)
     CastStreamingApiTest::SetUpCommandLine(command_line);
   }
 };
 
 // Tests the Cast streaming API and its basic functionality end-to-end.  An
 // extension subtest is run to generate test content, capture that content, and
 // use the API to send it out.  At the same time, this test launches an
 // in-process Cast receiver, listening on a localhost UDP socket, to receive the
 // content and check whether it matches expectations.
 //
@@ skipping 49 matching lines @@
 
   delete receiver;
   cast_environment->Shutdown();
 }
 
 IN_PROC_BROWSER_TEST_F(CastStreamingApiTestWithPixelOutput, RtpStreamError) {
   ASSERT_TRUE(RunExtensionSubtest("cast_streaming", "rtp_stream_error.html"));
 }
 
 }  // namespace extensions