Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: docs/updating_clang_format_binaries.md

Issue 1636073003: Remove pointless TODO comments someone added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | docs/writing_clang_plugins.md » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Updating Clang format binaries 1 # Updating Clang format binaries
2 2
3 Instructions on how to update the [clang-format binaries](clang_format.md) that 3 Instructions on how to update the [clang-format binaries](clang_format.md) that
4 come with a checkout of Chromium. 4 come with a checkout of Chromium.
5 5
6 ## Prerequisites 6 ## Prerequisites
7 7
8 You'll need a Windows machine, a Linux machine, and a Mac; all capable of 8 You'll need a Windows machine, a Linux machine, and a Mac; all capable of
9 building clang-format. You'll also need permissions to upload to the appropriate 9 building clang-format. You'll also need permissions to upload to the appropriate
10 google storage bucket. Chromium infrastructure team members have this, and 10 google storage bucket. Chromium infrastructure team members have this, and
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 -DLLVM_ENABLE_ASSERTIONS=NO -DLLVM_ENABLE_THREADS=NO ../llvm/ 69 -DLLVM_ENABLE_ASSERTIONS=NO -DLLVM_ENABLE_THREADS=NO ../llvm/
70 time caffeinate ninja clang-format 70 time caffeinate ninja clang-format
71 strip bin/clang-format 71 strip bin/clang-format
72 72
73 # (On Linux, to build with clang, which produces smaller binaries, add this to 73 # (On Linux, to build with clang, which produces smaller binaries, add this to
74 # your cmake invocation. 74 # your cmake invocation.
75 # On Mac, the system compiler is already clang so it's not needed there.) 75 # On Mac, the system compiler is already clang so it's not needed there.)
76 -DCMAKE_C_COMPILER=$PWD/../chrome/src/third_party/llvm-build/Release+Asserts/bin /clang -DCMAKE_CXX_COMPILER=$PWD/../chrome/src/third_party/llvm-build/Release+As serts/bin/clang++ 76 -DCMAKE_C_COMPILER=$PWD/../chrome/src/third_party/llvm-build/Release+Asserts/bin /clang -DCMAKE_CXX_COMPILER=$PWD/../chrome/src/third_party/llvm-build/Release+As serts/bin/clang++
77 ``` 77 ```
78 78
79 TODO: these ^^ instructions looks odd. Are they correct???
80
81 Platform specific notes: 79 Platform specific notes:
82 80
83 * Windows: Visual Studio 2013 only. 81 * Windows: Visual Studio 2013 only.
84 * Linux: so far (as of January 2014) we've just included a 64-bit binary. It's 82 * Linux: so far (as of January 2014) we've just included a 64-bit binary. It's
85 important to disable threading, else clang-format will depend on 83 important to disable threading, else clang-format will depend on
86 libatomic.so.1 which doesn't exist on Precise. 84 libatomic.so.1 which doesn't exist on Precise.
87 * Mac: Remember to set `MACOSX_DEPLOYMENT_TARGET` when building! If you get 85 * Mac: Remember to set `MACOSX_DEPLOYMENT_TARGET` when building! If you get
88 configure warnings, you may need to install XCode 5 and avoid a goma 86 configure warnings, you may need to install XCode 5 and avoid a goma
89 environment. 87 environment.
90 88
(...skipping 26 matching lines...) Expand all
117 The binaries were built at clang revision ####### on ####DATETIME####. 115 The binaries were built at clang revision ####### on ####DATETIME####.
118 116
119 BUG= 117 BUG=
120 118
121 The change should **always** include new `.sha1` files for each platform (we 119 The change should **always** include new `.sha1` files for each platform (we
122 want to keep these in lockstep), should **never** include `clang-format` 120 want to keep these in lockstep), should **never** include `clang-format`
123 binaries directly. The change should **always** update `README.chromium` 121 binaries directly. The change should **always** update `README.chromium`
124 122
125 clang-format binaries should weigh in at 1.5MB or less. Watch out for size 123 clang-format binaries should weigh in at 1.5MB or less. Watch out for size
126 regressions. 124 regressions.
OLDNEW
« no previous file with comments | « no previous file | docs/writing_clang_plugins.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698