Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1636033002: [interpreter] Fix how 'throw' is translated to TurboFan. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix how 'throw' is translated to TurboFan. This fixes the translation of 'throw' bytecodes to TurboFan graphs. The correct runtime function is being used now, also the frame states are attached to the correct nodes now. R=mythria@chromium.org TEST=cctest/test-run-jsexceptions/ThrowMessageIndirectly BUG=v8:4674 LOG=n Committed: https://crrev.com/fd5505ca15561bb8bc57bf0d3d490d3f8410aeea Cr-Commit-Position: refs/heads/master@{#33513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-26 12:48:00 UTC) #1
mythria
lgtm. Thanks for doing this.
4 years, 11 months ago (2016-01-26 13:12:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636033002/1
4 years, 11 months ago (2016-01-26 13:21:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 13:22:40 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 13:23:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd5505ca15561bb8bc57bf0d3d490d3f8410aeea
Cr-Commit-Position: refs/heads/master@{#33513}

Powered by Google App Engine
This is Rietveld 408576698