Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 163603003: add peekPixels to SkCanvas and SkSurface (Closed)

Created:
6 years, 10 months ago by reed2
Modified:
6 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add peekPixels to SkCanvas and SkSurface fix reference to SkBaseDevice, which was only a problem in no-gpu build This reverts commit 4fa44a6bf73891b21917fb90d02beef9143bffa3. Committed: http://code.google.com/p/skia/source/detail?r=13432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -305 lines) Patch
M gm/aaclip.cpp View 3 chunks +5 lines, -214 lines 0 comments Download
M gm/bitmapcopy.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M gm/bitmapsource.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/deviceproperties.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/displacement.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/gammatext.cpp View 2 chunks +14 lines, -6 lines 0 comments Download
M gm/gm.h View 1 chunk +1 line, -2 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/lighting.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/morphology.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/ninepatchstretch.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/offsetimagefilter.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
A gm/peekpixels.cpp View 1 chunk +78 lines, -0 lines 0 comments Download
M gm/tileimagefilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/xfermodes3.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkBitmap.h View 1 chunk +7 lines, -0 lines 0 comments Download
M include/core/SkBitmapDevice.h View 2 chunks +3 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 5 chunks +73 lines, -4 lines 0 comments Download
M include/core/SkDevice.h View 2 chunks +10 lines, -1 line 0 comments Download
M include/core/SkSurface.h View 1 chunk +12 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M samplecode/SampleCircle.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M samplecode/SampleLayers.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +49 lines, -0 lines 0 comments Download
M src/core/SkDevice.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/image/SkImagePriv.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/SkpSkGrTest.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 4 chunks +81 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
reed2
The CQ bit was checked by reed@chromium.org
6 years, 10 months ago (2014-02-13 16:02:15 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 16:02:23 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-13 16:02:24 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-13 16:04:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 16:04:13 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-13 16:04:14 UTC) #6
reed1
lgtm
6 years, 10 months ago (2014-02-13 16:05:29 UTC) #7
reed2
The CQ bit was checked by reed@chromium.org
6 years, 10 months ago (2014-02-13 16:05:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/163603003/1
6 years, 10 months ago (2014-02-13 16:05:58 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 17:14:59 UTC) #10
Message was sent while issue was closed. 
Change committed as 13432

Powered by Google App Engine
This is Rietveld 408576698