Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1636003003: [Android] Switch chromium bots on chromium.android to gn. (Closed)

Created:
4 years, 11 months ago by jbudorick
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, ghost stip (do not use), agrieve
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Switch chromium bots on chromium.android to gn. This still does not include cronet or webview. BUG=580129 Committed: https://crrev.com/1f63a1d9804b3c25dd896b52b3b3baf3700293fe Cr-Commit-Position: refs/heads/master@{#371641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M tools/mb/mb_config.pyl View 3 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
4 years, 11 months ago (2016-01-26 22:19:48 UTC) #2
Dirk Pranke
lgtm!
4 years, 11 months ago (2016-01-26 22:26:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636003003/1
4 years, 11 months ago (2016-01-26 22:37:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 23:59:27 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1f63a1d9804b3c25dd896b52b3b3baf3700293fe Cr-Commit-Position: refs/heads/master@{#371641}
4 years, 11 months ago (2016-01-27 00:00:25 UTC) #8
jbudorick
4 years, 11 months ago (2016-01-27 01:24:45 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1632343003/ by jbudorick@chromium.org.

The reason for reverting is: broken w/

ninja: Entering directory `/b/build/slave/android_build/build/src/out/Debug'
ninja: error: unknown target 'android_builder_tests'

or

In file included from ../../content/gpu/in_process_gpu_thread.cc:10:0:
../../content/gpu/gpu_child_thread.h:24:50: fatal error:
content/common/process_control.mojom.h: No such file or directory
 #include "content/common/process_control.mojom.h".

Powered by Google App Engine
This is Rietveld 408576698