Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 16360005: Remove V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS. (Closed)

Created:
7 years, 6 months ago by marja
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS. Blink has migrated to use the new style visitors. BUG= R=dcarney@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M include/v8.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
dcarney, svenpanne, ptal. This needs to wait for https://codereview.chromium.org/16226011/ before landing but that shouldn't take ...
7 years, 6 months ago (2013-06-04 12:04:46 UTC) #1
dcarney
lgtm
7 years, 6 months ago (2013-06-04 12:10:07 UTC) #2
Sven Panne
lgtm
7 years, 6 months ago (2013-06-04 12:17:00 UTC) #3
dcarney
7 years, 6 months ago (2013-06-04 13:36:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r14936 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698