Remove support for -webkit-column-span:1

Remove support for -webkit-column-span:1

This was an "alias" for -webkit-column-span:none. '1' is not a valid value,
according to the spec. The only valid values are 'none' and 'all'. In an older
version of the spec, '1' and 'all' were the valid values. In the latest version
(2011), '1' was changed to 'none'.

It's highly unlikely that removing this should cause compatibility problems.
The initial value is 'none' (which is what '1' was mapped to), so in order to
cause trouble, one would need a declaration -webkit-column-span:all to be
overridden by a -webkit-column-span:1. I went through httparchive to verify.
No sites were found to do this.

R=timloh@chromium.org

Committed: https://crrev.com/60ac870083a7f738905bcbbadbd3d5656e69fbf8
Cr-Commit-Position: refs/heads/master@{#371773}

[Timothy Loh, 2016-01-27 00:14:20]

lgtm

https://codereview.chromium.org/1635993002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1635993002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1487: CSSValueID
id = range.peek().id();
You could replace the body of this function with

return consumeIdent<CSSValueAll, CSSValueNone>(range);

[mstensho (USE GERRIT), 2016-01-27 09:53:08]

https://codereview.chromium.org/1635993002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1635993002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1487: CSSValueID
id = range.peek().id();
On 2016/01/27 00:14:20, Timothy Loh wrote:
> You could replace the body of this function with
> 
> return consumeIdent<CSSValueAll, CSSValueNone>(range);

Done.

Thanks!

[mstensho (USE GERRIT), 2016-01-27 09:53:13]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-01-27 09:53:13]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1635993002/#ps20001
(title: "Code review.")

[commit-bot: I haz the power, 2016-01-27 09:53:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1635993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1635993002/20001

[commit-bot: I haz the power, 2016-01-27 11:09:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-27 11:11:08]

Description was changed from

==========
Remove support for -webkit-column-span:1

This was an "alias" for -webkit-column-span:none. '1' is not a valid value,
according to the spec. The only valid values are 'none' and 'all'. In an older
version of the spec, '1' and 'all' were the valid values. In the latest version
(2011), '1' was changed to 'none'.

It's highly unlikely that removing this should cause compatibility problems.
The initial value is 'none' (which is what '1' was mapped to), so in order to
cause trouble, one would need a declaration -webkit-column-span:all to be
overridden by a -webkit-column-span:1. I went through httparchive to verify.
No sites were found to do this.

R=timloh@chromium.org
==========

to

==========
Remove support for -webkit-column-span:1

This was an "alias" for -webkit-column-span:none. '1' is not a valid value,
according to the spec. The only valid values are 'none' and 'all'. In an older
version of the spec, '1' and 'all' were the valid values. In the latest version
(2011), '1' was changed to 'none'.

It's highly unlikely that removing this should cause compatibility problems.
The initial value is 'none' (which is what '1' was mapped to), so in order to
cause trouble, one would need a declaration -webkit-column-span:all to be
overridden by a -webkit-column-span:1. I went through httparchive to verify.
No sites were found to do this.

R=timloh@chromium.org

Committed: https://crrev.com/60ac870083a7f738905bcbbadbd3d5656e69fbf8
Cr-Commit-Position: refs/heads/master@{#371773}
==========

[commit-bot: I haz the power, 2016-01-27 11:11:09]

Patchset 2 (id:??) landed as
https://crrev.com/60ac870083a7f738905bcbbadbd3d5656e69fbf8
Cr-Commit-Position: refs/heads/master@{#371773}