Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1635993002: Remove support for -webkit-column-span:1 (Closed)

Created:
4 years, 10 months ago by mstensho (USE GERRIT)
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, mstensho (USE GERRIT), rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for -webkit-column-span:1 This was an "alias" for -webkit-column-span:none. '1' is not a valid value, according to the spec. The only valid values are 'none' and 'all'. In an older version of the spec, '1' and 'all' were the valid values. In the latest version (2011), '1' was changed to 'none'. It's highly unlikely that removing this should cause compatibility problems. The initial value is 'none' (which is what '1' was mapped to), so in order to cause trouble, one would need a declaration -webkit-column-span:all to be overridden by a -webkit-column-span:1. I went through httparchive to verify. No sites were found to do this. R=timloh@chromium.org Committed: https://crrev.com/60ac870083a7f738905bcbbadbd3d5656e69fbf8 Cr-Commit-Position: refs/heads/master@{#371773}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/span/invalid-span-1.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/span/invalid-span-1-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Timothy Loh
lgtm https://codereview.chromium.org/1635993002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1635993002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode1487 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1487: CSSValueID id = range.peek().id(); You could replace the ...
4 years, 10 months ago (2016-01-27 00:14:20 UTC) #1
mstensho (USE GERRIT)
https://codereview.chromium.org/1635993002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1635993002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode1487 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1487: CSSValueID id = range.peek().id(); On 2016/01/27 00:14:20, Timothy Loh ...
4 years, 10 months ago (2016-01-27 09:53:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635993002/20001
4 years, 10 months ago (2016-01-27 09:53:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-27 11:09:50 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 11:11:09 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/60ac870083a7f738905bcbbadbd3d5656e69fbf8
Cr-Commit-Position: refs/heads/master@{#371773}

Powered by Google App Engine
This is Rietveld 408576698