content/browser/renderer_host/ime_adapter_android.cc - Issue 1635953002: Added replacement_range to ImeSetComposition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/ime_adapter_android.cc

Issue 1635953002: Added replacement_range to ImeSetComposition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: erikchen's review Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/ime_adapter_android.cc

diff --git a/content/browser/renderer_host/ime_adapter_android.cc b/content/browser/renderer_host/ime_adapter_android.cc

index d70d4969d2ed28d4e424fb372cd512d94019e2a7..2468b62db62bd6a7dd7c50267be43029d63242a4 100644

--- a/content/browser/renderer_host/ime_adapter_android.cc

+++ b/content/browser/renderer_host/ime_adapter_android.cc

@@ -203,7 +203,8 @@ void ImeAdapterAndroid::SetComposingText(JNIEnv* env,

if (new_cursor_pos > 0)

new_cursor_pos = text16.length() + new_cursor_pos - 1;

- rwhi->ImeSetComposition(text16, underlines, new_cursor_pos, new_cursor_pos);

+ rwhi->ImeSetComposition(text16, underlines, gfx::Range::InvalidRange(),

+ new_cursor_pos, new_cursor_pos);

}

void ImeAdapterAndroid::CommitText(JNIEnv* env,