Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1635913002: [chromecast] Statically link libcast_media_default for media unittests. (Closed)

Created:
4 years, 11 months ago by alokp
Modified:
4 years, 11 months ago
Reviewers:
slan, halliwell
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Statically link libcast_media_default for media unittests. BUG=577403 Committed: https://crrev.com/1eefe1cf48fc156be68c678a9e1d0523a22b7d13 Cr-Commit-Position: refs/heads/master@{#371416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chromecast/media/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alokp
4 years, 11 months ago (2016-01-26 00:55:51 UTC) #2
halliwell
On 2016/01/26 00:55:51, alokp wrote: lgtm
4 years, 11 months ago (2016-01-26 01:04:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635913002/1
4 years, 11 months ago (2016-01-26 01:17:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 01:55:20 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 01:56:46 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1eefe1cf48fc156be68c678a9e1d0523a22b7d13
Cr-Commit-Position: refs/heads/master@{#371416}

Powered by Google App Engine
This is Rietveld 408576698