Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1635883004: Revert of DevTools: do not use ScriptFunctionCall in the front-end embedder. (Closed)

Created:
4 years, 11 months ago by caseq
Modified:
4 years, 11 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: do not use ScriptFunctionCall in the front-end embedder. (patchset #1 id:1 of https://codereview.chromium.org/1577153002/ ) Reason for revert: Breaks context menu handling in DevTools front-end. Original issue's description: > DevTools: do not use ScriptFunctionCall in the front-end embedder. > > Committed: https://crrev.com/4a595ca1ace2d1592d154cac89b1085f7baa771b > Cr-Commit-Position: refs/heads/master@{#371337} TBR=dgozman@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2648dce45bec95da463053058e2e716aeaf5e194 Cr-Commit-Position: refs/heads/master@{#371579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -24 lines) Patch
M third_party/WebKit/Source/core/inspector/DevToolsHost.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/DevToolsHost.cpp View 7 chunks +29 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
caseq
Created Revert of DevTools: do not use ScriptFunctionCall in the front-end embedder.
4 years, 11 months ago (2016-01-26 20:26:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635883004/1
4 years, 11 months ago (2016-01-26 20:28:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 20:31:00 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 20:31:56 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2648dce45bec95da463053058e2e716aeaf5e194
Cr-Commit-Position: refs/heads/master@{#371579}

Powered by Google App Engine
This is Rietveld 408576698