Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: content/renderer/render_frame_impl_browsertest.cc

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3
Patch Set: Rebasing... Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_frame_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl_browsertest.cc
diff --git a/content/renderer/render_frame_impl_browsertest.cc b/content/renderer/render_frame_impl_browsertest.cc
index 00456c9a6a09036be6456d2416b701698cd198a0..10b6076f320d428b8f19beb03d62b8c32842587f 100644
--- a/content/renderer/render_frame_impl_browsertest.cc
+++ b/content/renderer/render_frame_impl_browsertest.cc
@@ -50,15 +50,18 @@ class RenderFrameImplTest : public RenderViewTest {
LoadHTML("Parent frame <iframe name='frame'></iframe>");
+ FrameReplicationState frame_replication_state;
+ frame_replication_state.name = "frame";
+ frame_replication_state.unique_name = "frame-uniqueName";
+
RenderFrameImpl::FromWebFrame(
view_->GetMainRenderFrame()->GetWebFrame()->firstChild())
- ->OnSwapOut(kFrameProxyRouteId, false, FrameReplicationState());
+ ->OnSwapOut(kFrameProxyRouteId, false, frame_replication_state);
- RenderFrameImpl::CreateFrame(kSubframeRouteId, MSG_ROUTING_NONE,
- MSG_ROUTING_NONE, kFrameProxyRouteId,
- MSG_ROUTING_NONE, FrameReplicationState(),
- &compositor_deps_, widget_params,
- blink::WebFrameOwnerProperties());
+ RenderFrameImpl::CreateFrame(
+ kSubframeRouteId, MSG_ROUTING_NONE, MSG_ROUTING_NONE,
+ kFrameProxyRouteId, MSG_ROUTING_NONE, frame_replication_state,
+ &compositor_deps_, widget_params, blink::WebFrameOwnerProperties());
frame_ = RenderFrameImpl::FromRoutingID(kSubframeRouteId);
EXPECT_FALSE(frame_->is_main_frame_);
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_frame_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698