Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3
Patch Set: Rebasing... Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index 3b0f307c2e277a71f8c273dcce8e21b9ffcddc63..df798cfc97d3f34cde8b27183a7adcb62aaf2eb2 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -955,7 +955,8 @@ void RenderFrameHostManager::OnDidStopLoading() {
}
}
-void RenderFrameHostManager::OnDidUpdateName(const std::string& name) {
+void RenderFrameHostManager::OnDidUpdateName(const std::string& name,
+ const std::string& unique_name) {
// The window.name message may be sent outside of --site-per-process when
// report_frame_name_changes renderer preference is set (used by
// WebView). Don't send the update to proxies in those cases.
@@ -965,8 +966,8 @@ void RenderFrameHostManager::OnDidUpdateName(const std::string& name) {
return;
for (const auto& pair : proxy_hosts_) {
- pair.second->Send(
- new FrameMsg_DidUpdateName(pair.second->GetRoutingID(), name));
+ pair.second->Send(new FrameMsg_DidUpdateName(pair.second->GetRoutingID(),
+ name, unique_name));
}
}
@@ -1816,7 +1817,8 @@ void RenderFrameHostManager::CreateOuterDelegateProxy(
// investigate and fix.
render_frame_host->Send(new FrameMsg_SwapOut(
render_frame_host->GetRoutingID(), proxy->GetRoutingID(),
- false /* is_loading */, FrameReplicationState()));
+ false /* is_loading */,
+ render_frame_host->frame_tree_node()->current_replication_state()));
proxy->set_render_frame_proxy_created(true);
}

Powered by Google App Engine
This is Rietveld 408576698