content/renderer/render_frame_proxy.h - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_proxy.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Added FrameTreeHelpers::createLocalChild. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_frame_impl_browsertest.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_proxy.h

diff --git a/content/renderer/render_frame_proxy.h b/content/renderer/render_frame_proxy.h

index f6dc70054cf17d0771f7778e82da3a2daa783bea..5986e16199b45877ef1547f40e7112afa4797bda 100644

--- a/content/renderer/render_frame_proxy.h

+++ b/content/renderer/render_frame_proxy.h

@@ -171,7 +171,7 @@ class CONTENT_EXPORT RenderFrameProxy

void OnDidStopLoading();

void OnDidUpdateSandboxFlags(blink::WebSandboxFlags flags);

void OnDispatchLoad();

- void OnDidUpdateName(const std::string& name);

+ void OnDidUpdateName(const std::string& name, const std::string& unique_name);

void OnEnforceStrictMixedContentChecking(bool should_enforce);

void OnDidUpdateOrigin(const url::Origin& origin);

void OnSetPageFocus(bool is_focused);