content/test/test_render_frame_host.cc - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_render_frame_host.cc

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Addressed CR feedback from Charlie. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_frame_proxy.cc ('k') | third_party/WebKit/LayoutTests/FlagExpectations/site-per-process » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/test_render_frame_host.cc

diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc

index 86944830c772f136d0177dd673d6e1c93b57a8e3..a6f3ee2898f31bc618820dd0d540e01a21ee2319 100644

--- a/content/test/test_render_frame_host.cc

+++ b/content/test/test_render_frame_host.cc

@@ -4,6 +4,7 @@

#include "content/test/test_render_frame_host.h"

+#include "base/guid.h"

#include "content/browser/frame_host/frame_tree.h"

#include "content/browser/frame_host/navigation_handle_impl.h"

#include "content/browser/frame_host/navigation_request.h"

@@ -82,9 +83,10 @@ void TestRenderFrameHost::InitializeRenderFrameIfNeeded() {

TestRenderFrameHost* TestRenderFrameHost::AppendChild(

const std::string& frame_name) {

+ std::string frame_unique_name = base::GenerateGUID();

OnCreateChildFrame(GetProcess()->GetNextRoutingID(),

blink::WebTreeScopeType::Document, frame_name,

- blink::WebSandboxFlags::None,

+ frame_unique_name, blink::WebSandboxFlags::None,

blink::WebFrameOwnerProperties());

return static_cast<TestRenderFrameHost*>(

child_creation_observer_.last_created_frame());