content/browser/frame_host/render_frame_message_filter.h - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_message_filter.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Addressed CR feedback from Charlie. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_unittest.cc ('k') | content/browser/frame_host/render_frame_message_filter.cc » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_message_filter.h

diff --git a/content/browser/frame_host/render_frame_message_filter.h b/content/browser/frame_host/render_frame_message_filter.h

index 194e2079b44b13896d3a1f153c23ab03ed3f9127..cde7f5e2a131c66d21341b996aa500fc5fde50d2 100644

--- a/content/browser/frame_host/render_frame_message_filter.h

+++ b/content/browser/frame_host/render_frame_message_filter.h

@@ -20,6 +20,7 @@

#include "content/common/pepper_renderer_instance_data.h"

#endif

+struct FrameHostMsg_CreateChildFrame_Params;

class GURL;

namespace net {

@@ -61,13 +62,8 @@ class RenderFrameMessageFilter : public BrowserMessageFilter {

~RenderFrameMessageFilter() override;

- void OnCreateChildFrame(

- int parent_routing_id,

- blink::WebTreeScopeType scope,

- const std::string& frame_name,

- blink::WebSandboxFlags sandbox_flags,

- const blink::WebFrameOwnerProperties& frame_owner_properties,

- int* new_render_frame_id);

+ void OnCreateChildFrame(const FrameHostMsg_CreateChildFrame_Params& params,

+ int* new_render_frame_id);

void OnSetCookie(int render_frame_id,

const GURL& url,

const GURL& first_party_for_cookies,