content/browser/frame_host/render_frame_host_impl.h - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Addressed CR feedback from Charlie. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index 9767a4a5018b459a68f507ec47e21d41499c7abd..dd9fdb1aea0c9df358bb035bfb1bc54f6b6b8d2a 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -227,6 +227,7 @@ class CONTENT_EXPORT RenderFrameHostImpl

int new_routing_id,

blink::WebTreeScopeType scope,

const std::string& frame_name,

+ const std::string& frame_unique_name,

blink::WebSandboxFlags sandbox_flags,

const blink::WebFrameOwnerProperties& frame_owner_properties);

@@ -597,7 +598,7 @@ class CONTENT_EXPORT RenderFrameHostImpl

uint32_t end_offset);

void OnDidAccessInitialDocument();

void OnDidChangeOpener(int32_t opener_routing_id);

- void OnDidChangeName(const std::string& name);

+ void OnDidChangeName(const std::string& name, const std::string& unique_name);

void OnEnforceStrictMixedContentChecking();

void OnDidAssignPageId(int32_t page_id);

void OnDidChangeSandboxFlags(int32_t frame_routing_id,