content/browser/frame_host/render_frame_host_manager.h - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Fixing fallout from the new assert in FrameTree.cpp. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | content/browser/frame_host/render_frame_host_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.h

diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h

index e208aa4c9838313cb287f466e8374cdb48ca03eb..fd5454f880e80888a87c1fb0360847c1422a27e1 100644

--- a/content/browser/frame_host/render_frame_host_manager.h

+++ b/content/browser/frame_host/render_frame_host_manager.h

@@ -433,9 +433,10 @@ class CONTENT_EXPORT RenderFrameHostManager

void OnDidStartLoading();

void OnDidStopLoading();

- // Send updated frame name to all frame proxies when the frame changes its

- // window.name property.

- void OnDidUpdateName(const std::string& name);

+ // OnDidUpdateName gets called when a frame changes its name - it gets the new

+ // |name| and the recalculated |unique_name| and replicates them into all

+ // frame proxies.

+ void OnDidUpdateName(const std::string& name, const std::string& unique_name);

// Sends updated enforcement of strict mixed content checking to all

// frame proxies when the frame changes its setting.