content/browser/frame_host/frame_tree.cc - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree.cc

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Fixing fallout from the new assert in FrameTree.cpp. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/frame_tree.h ('k') | content/browser/frame_host/frame_tree_node.h » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/frame_tree.cc

diff --git a/content/browser/frame_host/frame_tree.cc b/content/browser/frame_host/frame_tree.cc

index 5e8b2c1d481279fe4c88728d6ccdf4d2455be6e6..ee498ade8a0d1325921e5a8858ee4d49af4ca626 100644

--- a/content/browser/frame_host/frame_tree.cc

+++ b/content/browser/frame_host/frame_tree.cc

@@ -99,6 +99,7 @@ FrameTree::FrameTree(Navigator* navigator,

// document scope.

blink::WebTreeScopeType::Document,

std::string(),

+ std::string(),

blink::WebFrameOwnerProperties())),

focused_frame_tree_node_id_(-1),

load_progress_(0.0) {}

@@ -162,6 +163,7 @@ bool FrameTree::AddFrame(

int new_routing_id,

blink::WebTreeScopeType scope,

const std::string& frame_name,

+ const std::string& frame_unique_name,

blink::WebSandboxFlags sandbox_flags,

const blink::WebFrameOwnerProperties& frame_owner_properties) {

CHECK_NE(new_routing_id, MSG_ROUTING_NONE);

@@ -178,7 +180,7 @@ bool FrameTree::AddFrame(

make_scoped_ptr(new FrameTreeNode(

this, parent->navigator(), render_frame_delegate_,

render_view_delegate_, render_widget_delegate_, manager_delegate_,

- scope, frame_name, frame_owner_properties)),

+ scope, frame_name, frame_unique_name, frame_owner_properties)),

process_id, new_routing_id);

// Set sandbox flags and make them effective immediately, since initial