Chromium Code Reviews

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3
Patch Set: Removed unnecessary crbug comment. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: third_party/WebKit/public/web/WebFrameClient.h
diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h
index 86c77e29ce1448512f34e31f13454ac413dc39cf..461eff3a44f78f991e0f125e095e208c36f5abb2 100644
--- a/third_party/WebKit/public/web/WebFrameClient.h
+++ b/third_party/WebKit/public/web/WebFrameClient.h
@@ -156,7 +156,7 @@ public:
// until frameDetached() is called on it.
// Note: If you override this, you should almost certainly be overriding
// frameDetached().
- virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, WebSandboxFlags sandboxFlags, const WebFrameOwnerProperties&) { return nullptr; }
+ virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, const WebString& frameUniqueName, WebSandboxFlags sandboxFlags, const WebFrameOwnerProperties&) { return nullptr; }
// This frame has set its opener to another frame, or disowned the opener
// if opener is null. See http://html.spec.whatwg.org/#dom-opener.
@@ -176,7 +176,7 @@ public:
virtual void willClose(WebFrame*) { }
// This frame's name has changed.
- virtual void didChangeName(WebLocalFrame*, const WebString&) { }
+ virtual void didChangeName(WebLocalFrame*, const WebString& name, const WebString& uniqueName) { }
// This frame has been set to enforce strict mixed content checking.
virtual void didEnforceStrictMixedContentChecking() {}

Powered by Google App Engine