components/printing/renderer/print_web_view_helper.cc - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Removed unnecessary crbug comment. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/html_viewer/html_frame.cc ('K') | « components/html_viewer/html_frame.cc ('k') | content/browser/frame_host/frame_tree.h » ('j') | content/browser/frame_host/frame_tree_node.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/printing/renderer/print_web_view_helper.cc

diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc

index dce40c4843d018a692da2fdb2ac5d5168506dea0..aedc8e0c97f456e61460c10952dcbe226c01da5c 100644

--- a/components/printing/renderer/print_web_view_helper.cc

+++ b/components/printing/renderer/print_web_view_helper.cc

@@ -616,6 +616,7 @@ class PrepareFrameAndViewForPrint : public blink::WebViewClient,

blink::WebLocalFrame* parent,

blink::WebTreeScopeType scope,

const blink::WebString& name,

+ const blink::WebString& uniqueName,

blink::WebSandboxFlags sandboxFlags,

const blink::WebFrameOwnerProperties& frameOwnerProperties) override;

void frameDetached(blink::WebFrame* frame, DetachType type) override;

@@ -759,9 +760,10 @@ void PrepareFrameAndViewForPrint::didStopLoading() {

blink::WebFrame* PrepareFrameAndViewForPrint::createChildFrame(

blink::WebLocalFrame* parent,

blink::WebTreeScopeType scope,

- const blink::WebString& name,

- blink::WebSandboxFlags sandboxFlags,

- const blink::WebFrameOwnerProperties& frameOwnerProperties) {

+ const blink::WebString& /* name */,

+ const blink::WebString& /* uniqueName */,

+ blink::WebSandboxFlags /* sandboxFlags */,

+ const blink::WebFrameOwnerProperties& /* frameOwnerProperties */) {

blink::WebFrame* frame = blink::WebLocalFrame::create(scope, this);

parent->appendChild(frame);

return frame;