components/html_viewer/html_frame.h - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/html_frame.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Removed unnecessary crbug comment. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/html_viewer/html_frame.h

diff --git a/components/html_viewer/html_frame.h b/components/html_viewer/html_frame.h

index 1d7e7c3bfe0721995b9737a410343250e44e8609..aca7e430821bb2c938cbc83e3015d50defe22c89 100644

--- a/components/html_viewer/html_frame.h

+++ b/components/html_viewer/html_frame.h

@@ -172,7 +172,8 @@ class HTMLFrame : public blink::WebFrameClient,

blink::WebFrame* createChildFrame(

blink::WebLocalFrame* parent,

blink::WebTreeScopeType scope,

- const blink::WebString& frame_ame,

+ const blink::WebString& frame_name,

+ const blink::WebString& frame_unique_name,

blink::WebSandboxFlags sandbox_flags,

const blink::WebFrameOwnerProperties& frame_owner_properties) override;

void frameDetached(blink::WebFrame* frame,

@@ -197,7 +198,8 @@ class HTMLFrame : public blink::WebFrameClient,

void didChangeLoadProgress(double load_progress) override;

void dispatchLoad() override;

void didChangeName(blink::WebLocalFrame* frame,

- const blink::WebString& name) override;

+ const blink::WebString& name,

+ const blink::WebString& uniqueName) override;

void didCommitProvisionalLoad(

blink::WebLocalFrame* frame,

const blink::WebHistoryItem& item,

« no previous file with comments | « no previous file | components/html_viewer/html_frame.cc » ('j') | components/html_viewer/html_frame.cc » ('J')