Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameImplBase.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3
Patch Set: Rebasing... Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebFrameImplBase_h 5 #ifndef WebFrameImplBase_h
6 #define WebFrameImplBase_h 6 #define WebFrameImplBase_h
7 7
8 #include "platform/heap/Handle.h" 8 #include "platform/heap/Handle.h"
9 #include "wtf/text/AtomicString.h" 9 #include "wtf/text/AtomicString.h"
10 10
(...skipping 13 matching lines...) Expand all
24 // 24 //
25 // To get around this, only the private implementations have WebFrameImplBase as 25 // To get around this, only the private implementations have WebFrameImplBase as
26 // a base class. WebFrame exposes a virtual accessor to retrieve the underlying 26 // a base class. WebFrame exposes a virtual accessor to retrieve the underlying
27 // implementation as an instance of the base class, but has no inheritance 27 // implementation as an instance of the base class, but has no inheritance
28 // relationship with it. The cost is a virtual indirection, but this is nicer 28 // relationship with it. The cost is a virtual indirection, but this is nicer
29 // than the previous manual dispatch emulating real virtual dispatch. 29 // than the previous manual dispatch emulating real virtual dispatch.
30 class WebFrameImplBase : public RefCountedWillBeGarbageCollectedFinalized<WebFra meImplBase> { 30 class WebFrameImplBase : public RefCountedWillBeGarbageCollectedFinalized<WebFra meImplBase> {
31 public: 31 public:
32 virtual ~WebFrameImplBase(); 32 virtual ~WebFrameImplBase();
33 33
34 virtual void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString & name, const AtomicString& fallbackName) = 0; 34 virtual void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString & name, const AtomicString& uniqueName) = 0;
35 // TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be const... 35 // TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be const...
36 virtual Frame* frame() const = 0; 36 virtual Frame* frame() const = 0;
37 37
38 DECLARE_VIRTUAL_TRACE(); 38 DECLARE_VIRTUAL_TRACE();
39 }; 39 };
40 40
41 } // namespace blink 41 } // namespace blink
42 42
43 #endif // WebFrameImplBase_h 43 #endif // WebFrameImplBase_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebFrame.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698