Replicating WebFrame::uniqueName across renderers.

content/browser/frame_host/frame_tree_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/frame_tree.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
@@ skipping 138 matching lines @@
   int process_id = root->current_frame_host()->GetProcess()->GetID();
 
   // Do not navigate each frame separately, since that will clutter the test
   // itself. Instead, leave them in "not live" state, which is indicated by the
   // * after the frame id, since this test cares about the shape, not the
   // frame liveness.
   EXPECT_EQ("2: []", GetTreeState(frame_tree));
 
   // Simulate attaching a series of frames to build the frame tree.
   frame_tree->AddFrame(root, process_id, 14, blink::WebTreeScopeType::Document,
-                       std::string(), blink::WebSandboxFlags::None,
+                       std::string(), "uniqueName0",
+                       blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
   frame_tree->AddFrame(root, process_id, 15, blink::WebTreeScopeType::Document,
-                       std::string(), blink::WebSandboxFlags::None,
+                       std::string(), "uniqueName1",
+                       blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
   frame_tree->AddFrame(root, process_id, 16, blink::WebTreeScopeType::Document,
-                       std::string(), blink::WebSandboxFlags::None,
+                       std::string(), "uniqueName2",
+                       blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
 
   frame_tree->AddFrame(root->child_at(0), process_id, 244,
                        blink::WebTreeScopeType::Document, std::string(),
-                       blink::WebSandboxFlags::None,
+                       "uniqueName3", blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
   frame_tree->AddFrame(root->child_at(1), process_id, 255,
                        blink::WebTreeScopeType::Document, no_children_node,
-                       blink::WebSandboxFlags::None,
+                       "uniqueName4", blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
   frame_tree->AddFrame(root->child_at(0), process_id, 245,
                        blink::WebTreeScopeType::Document, std::string(),
-                       blink::WebSandboxFlags::None,
+                       "uniqueName5", blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
 
   EXPECT_EQ(
       "2: [14: [244: [], 245: []], "
       "15: [255 'no children node': []], "
       "16: []]",
       GetTreeState(frame_tree));
 
   FrameTreeNode* child_16 = root->child_at(2);
   frame_tree->AddFrame(child_16, process_id, 264,
                        blink::WebTreeScopeType::Document, std::string(),
-                       blink::WebSandboxFlags::None,
+                       "uniqueName6", blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
   frame_tree->AddFrame(child_16, process_id, 265,
                        blink::WebTreeScopeType::Document, std::string(),
-                       blink::WebSandboxFlags::None,
+                       "uniqueName7", blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
   frame_tree->AddFrame(child_16, process_id, 266,
                        blink::WebTreeScopeType::Document, std::string(),
-                       blink::WebSandboxFlags::None,
+                       "uniqueName8", blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
   frame_tree->AddFrame(child_16, process_id, 267,
                        blink::WebTreeScopeType::Document, deep_subtree,
-                       blink::WebSandboxFlags::None,
+                       "uniqueName9", blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
   frame_tree->AddFrame(child_16, process_id, 268,
                        blink::WebTreeScopeType::Document, std::string(),
-                       blink::WebSandboxFlags::None,
+                       "uniqueName10", blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
 
   FrameTreeNode* child_267 = child_16->child_at(3);
   frame_tree->AddFrame(child_267, process_id, 365,
                        blink::WebTreeScopeType::Document, std::string(),
-                       blink::WebSandboxFlags::None,
+                       "uniqueName11", blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
   frame_tree->AddFrame(child_267->child_at(0), process_id, 455,
                        blink::WebTreeScopeType::Document, std::string(),
-                       blink::WebSandboxFlags::None,
+                       "uniqueName12", blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
   frame_tree->AddFrame(child_267->child_at(0)->child_at(0), process_id, 555,
                        blink::WebTreeScopeType::Document, std::string(),
-                       blink::WebSandboxFlags::None,
+                       "uniqueName13", blink::WebSandboxFlags::None,
                        blink::WebFrameOwnerProperties());
-  frame_tree->AddFrame(child_267->child_at(0)->child_at(0)->child_at(0),
-                       process_id, 655, blink::WebTreeScopeType::Document,
-                       std::string(), blink::WebSandboxFlags::None,
-                       blink::WebFrameOwnerProperties());
+  frame_tree->AddFrame(
+      child_267->child_at(0)->child_at(0)->child_at(0), process_id, 655,
+      blink::WebTreeScopeType::Document, std::string(), "uniqueName14",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
 
   // Now that's it's fully built, verify the tree structure is as expected.
   EXPECT_EQ(
       "2: [14: [244: [], 245: []], "
       "15: [255 'no children node': []], "
       "16: [264: [], 265: [], 266: [], "
       "267 'node with deep subtree': "
       "[365: [455: [555: [655: []]]]], 268: []]]",
       GetTreeState(frame_tree));
 
@@ skipping 50 matching lines @@
 }
 
 // Ensure frames can be found by frame_tree_node_id, routing ID, or name.
 TEST_F(FrameTreeTest, FindFrames) {
   main_test_rfh()->InitializeRenderFrameIfNeeded();
 
   // Add a few child frames to the main frame.
   FrameTree* frame_tree = contents()->GetFrameTree();
   FrameTreeNode* root = frame_tree->root();
 
-  main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
-                                      "child0", blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
-  main_test_rfh()->OnCreateChildFrame(23, blink::WebTreeScopeType::Document,
-                                      "child1", blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
-  main_test_rfh()->OnCreateChildFrame(24, blink::WebTreeScopeType::Document,
-                                      std::string(),
-                                      blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      22, blink::WebTreeScopeType::Document, "child0", "uniqueName0",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      23, blink::WebTreeScopeType::Document, "child1", "uniqueName1",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      24, blink::WebTreeScopeType::Document, std::string(), "uniqueName2",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
   FrameTreeNode* child0 = root->child_at(0);
   FrameTreeNode* child1 = root->child_at(1);
 
   FrameTreeNode* child2 = root->child_at(2);
 
   // Add one grandchild frame.
   child1->current_frame_host()->OnCreateChildFrame(
-      33, blink::WebTreeScopeType::Document, "grandchild",
+      33, blink::WebTreeScopeType::Document, "grandchild", "uniqueName3",
       blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
   FrameTreeNode* grandchild = child1->child_at(0);
 
   // Ensure they can be found by FTN id.
   EXPECT_EQ(root, frame_tree->FindByID(root->frame_tree_node_id()));
   EXPECT_EQ(child0, frame_tree->FindByID(child0->frame_tree_node_id()));
   EXPECT_EQ(child1, frame_tree->FindByID(child1->frame_tree_node_id()));
   EXPECT_EQ(child2, frame_tree->FindByID(child2->frame_tree_node_id()));
   EXPECT_EQ(grandchild, frame_tree->FindByID(grandchild->frame_tree_node_id()));
   EXPECT_EQ(nullptr, frame_tree->FindByID(-1));
@@ skipping 16 matching lines @@
   EXPECT_EQ(nullptr, frame_tree->FindByName("no such frame"));
 }
 
 // Check that PreviousSibling() is retrieved correctly.
 TEST_F(FrameTreeTest, PreviousSibling) {
   main_test_rfh()->InitializeRenderFrameIfNeeded();
 
   // Add a few child frames to the main frame.
   FrameTree* frame_tree = contents()->GetFrameTree();
   FrameTreeNode* root = frame_tree->root();
-  main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
-                                      "child0", blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
-  main_test_rfh()->OnCreateChildFrame(23, blink::WebTreeScopeType::Document,
-                                      "child1", blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
-  main_test_rfh()->OnCreateChildFrame(24, blink::WebTreeScopeType::Document,
-                                      "child2", blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      22, blink::WebTreeScopeType::Document, "child0", "uniqueName0",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      23, blink::WebTreeScopeType::Document, "child1", "uniqueName1",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      24, blink::WebTreeScopeType::Document, "child2", "uniqueName2",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
   FrameTreeNode* child0 = root->child_at(0);
   FrameTreeNode* child1 = root->child_at(1);
   FrameTreeNode* child2 = root->child_at(2);
 
   // Add one grandchild frame.
   child1->current_frame_host()->OnCreateChildFrame(
-      33, blink::WebTreeScopeType::Document, "grandchild",
+      33, blink::WebTreeScopeType::Document, "grandchild", "uniqueName3",
       blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
   FrameTreeNode* grandchild = child1->child_at(0);
 
   EXPECT_EQ(nullptr, root->PreviousSibling());
   EXPECT_EQ(nullptr, child0->PreviousSibling());
   EXPECT_EQ(child0, child1->PreviousSibling());
   EXPECT_EQ(child1, child2->PreviousSibling());
   EXPECT_EQ(nullptr, grandchild->PreviousSibling());
 }
 
 // Do some simple manipulations of the frame tree, making sure that
 // WebContentsObservers see a consistent view of the tree as we go.
 TEST_F(FrameTreeTest, ObserverWalksTreeDuringFrameCreation) {
   TreeWalkingWebContentsLogger activity(contents());
   contents()->NavigateAndCommit(GURL("http://www.google.com"));
   EXPECT_EQ("RenderFrameCreated(2) -> 2: []", activity.GetLog());
 
   FrameTree* frame_tree = contents()->GetFrameTree();
   FrameTreeNode* root = frame_tree->root();
 
   // Simulate attaching a series of frames to build the frame tree.
-  main_test_rfh()->OnCreateChildFrame(14, blink::WebTreeScopeType::Document,
-                                      std::string(),
-                                      blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      14, blink::WebTreeScopeType::Document, std::string(), "uniqueName0",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
   EXPECT_EQ(
       "RenderFrameHostChanged(new)(14) -> 2: []\n"
       "RenderFrameCreated(14) -> 2: [14: []]",
       activity.GetLog());
-  main_test_rfh()->OnCreateChildFrame(18, blink::WebTreeScopeType::Document,
-                                      std::string(),
-                                      blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      18, blink::WebTreeScopeType::Document, std::string(), "uniqueName1",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
   EXPECT_EQ(
       "RenderFrameHostChanged(new)(18) -> 2: [14: []]\n"
       "RenderFrameCreated(18) -> 2: [14: [], 18: []]",
       activity.GetLog());
   frame_tree->RemoveFrame(root->child_at(0));
   EXPECT_EQ("RenderFrameDeleted(14) -> 2: [18: []]", activity.GetLog());
   frame_tree->RemoveFrame(root->child_at(0));
   EXPECT_EQ("RenderFrameDeleted(18) -> 2: []", activity.GetLog());
 }
 
 // Make sure that WebContentsObservers see a consistent view of the tree after
 // recovery from a render process crash.
 TEST_F(FrameTreeTest, ObserverWalksTreeAfterCrash) {
   TreeWalkingWebContentsLogger activity(contents());
   contents()->NavigateAndCommit(GURL("http://www.google.com"));
   EXPECT_EQ("RenderFrameCreated(2) -> 2: []", activity.GetLog());
 
-  main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
-                                      std::string(),
-                                      blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      22, blink::WebTreeScopeType::Document, std::string(), "uniqueName0",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
   EXPECT_EQ(
       "RenderFrameHostChanged(new)(22) -> 2: []\n"
       "RenderFrameCreated(22) -> 2: [22: []]",
       activity.GetLog());
-  main_test_rfh()->OnCreateChildFrame(23, blink::WebTreeScopeType::Document,
-                                      std::string(),
-                                      blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      23, blink::WebTreeScopeType::Document, std::string(), "uniqueName1",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
   EXPECT_EQ(
       "RenderFrameHostChanged(new)(23) -> 2: [22: []]\n"
       "RenderFrameCreated(23) -> 2: [22: [], 23: []]",
       activity.GetLog());
 
   // Crash the renderer
   main_test_rfh()->GetProcess()->SimulateCrash();
   EXPECT_EQ(
       "RenderProcessGone -> 2*: [22*: [], 23*: []]\n"
       "RenderFrameDeleted(23) -> 2*: [22*: [], 23*: []]\n"
       "RenderFrameDeleted(22) -> 2*: [22*: [], 23*: []]\n"
       "RenderFrameDeleted(2) -> 2*: []",
       activity.GetLog());
 }
 
 // Ensure that frames are not added to the tree, if the process passed in
 // is different than the process of the parent node.
 TEST_F(FrameTreeTest, FailAddFrameWithWrongProcessId) {
   contents()->NavigateAndCommit(GURL("http://www.google.com"));
   FrameTree* frame_tree = contents()->GetFrameTree();
   FrameTreeNode* root = frame_tree->root();
   int process_id = root->current_frame_host()->GetProcess()->GetID();
 
   ASSERT_EQ("2: []", GetTreeState(frame_tree));
 
   // Simulate attaching a frame from mismatched process id.
   ASSERT_FALSE(frame_tree->AddFrame(
       root, process_id + 1, 1, blink::WebTreeScopeType::Document, std::string(),
-      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties()));
+      "uniqueName0", blink::WebSandboxFlags::None,
+      blink::WebFrameOwnerProperties()));
   ASSERT_EQ("2: []", GetTreeState(frame_tree));
 }
 
 // Ensure that frames removed while a process has crashed are not preserved in
 // the global map of id->frame.
 TEST_F(FrameTreeTest, ProcessCrashClearsGlobalMap) {
   main_test_rfh()->InitializeRenderFrameIfNeeded();
 
   // Add a couple child frames to the main frame.
   FrameTreeNode* root = contents()->GetFrameTree()->root();
 
-  main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
-                                      std::string(),
-                                      blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
-  main_test_rfh()->OnCreateChildFrame(23, blink::WebTreeScopeType::Document,
-                                      std::string(),
-                                      blink::WebSandboxFlags::None,
-                                      blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      22, blink::WebTreeScopeType::Document, std::string(), "uniqueName0",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
+  main_test_rfh()->OnCreateChildFrame(
+      23, blink::WebTreeScopeType::Document, std::string(), "uniqueName1",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
 
   // Add one grandchild frame.
   RenderFrameHostImpl* child1_rfh = root->child_at(0)->current_frame_host();
-  child1_rfh->OnCreateChildFrame(33, blink::WebTreeScopeType::Document,
-                                 std::string(), blink::WebSandboxFlags::None,
-                                 blink::WebFrameOwnerProperties());
+  child1_rfh->OnCreateChildFrame(
+      33, blink::WebTreeScopeType::Document, std::string(), "uniqueName2",
+      blink::WebSandboxFlags::None, blink::WebFrameOwnerProperties());
 
   // Ensure they can be found by id.
   int id1 = root->child_at(0)->frame_tree_node_id();
   int id2 = root->child_at(1)->frame_tree_node_id();
   int id3 = root->child_at(0)->child_at(0)->frame_tree_node_id();
   EXPECT_TRUE(FrameTreeNode::GloballyFindByID(id1));
   EXPECT_TRUE(FrameTreeNode::GloballyFindByID(id2));
   EXPECT_TRUE(FrameTreeNode::GloballyFindByID(id3));
 
   // Crash the renderer.
   main_test_rfh()->GetProcess()->SimulateCrash();
 
   // Ensure they cannot be found by id after the process has crashed.
   EXPECT_FALSE(FrameTreeNode::GloballyFindByID(id1));
   EXPECT_FALSE(FrameTreeNode::GloballyFindByID(id2));
   EXPECT_FALSE(FrameTreeNode::GloballyFindByID(id3));
 }
 
 }  // namespace content