Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3
Patch Set: Addressed CR feedback from Charlie. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 // document of a main frame. After this, it is no longer safe to show a 149 // document of a main frame. After this, it is no longer safe to show a
150 // pending navigation's URL, because a URL spoof is possible. 150 // pending navigation's URL, because a URL spoof is possible.
151 virtual void didAccessInitialDocument(WebLocalFrame*) { } 151 virtual void didAccessInitialDocument(WebLocalFrame*) { }
152 152
153 // A child frame was created in this frame. This is called when the frame 153 // A child frame was created in this frame. This is called when the frame
154 // is created and initialized. Takes the name of the new frame, the parent 154 // is created and initialized. Takes the name of the new frame, the parent
155 // frame and returns a new WebFrame. The WebFrame is considered in-use 155 // frame and returns a new WebFrame. The WebFrame is considered in-use
156 // until frameDetached() is called on it. 156 // until frameDetached() is called on it.
157 // Note: If you override this, you should almost certainly be overriding 157 // Note: If you override this, you should almost certainly be overriding
158 // frameDetached(). 158 // frameDetached().
159 virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, WebSandboxFlags sandboxFlags, const WebFrameOwnerPro perties&) { return nullptr; } 159 virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, const WebString& frameUniqueName, WebSandboxFlags sa ndboxFlags, const WebFrameOwnerProperties&) { return nullptr; }
dcheng 2016/02/16 22:17:30 const WebString& name, const WebString& uniqueName
Łukasz Anforowicz 2016/02/16 23:39:53 Done.
160 160
161 // This frame has set its opener to another frame, or disowned the opener 161 // This frame has set its opener to another frame, or disowned the opener
162 // if opener is null. See http://html.spec.whatwg.org/#dom-opener. 162 // if opener is null. See http://html.spec.whatwg.org/#dom-opener.
163 virtual void didChangeOpener(WebFrame*) { } 163 virtual void didChangeOpener(WebFrame*) { }
164 164
165 // Specifies the reason for the detachment. 165 // Specifies the reason for the detachment.
166 enum class DetachType { Remove, Swap }; 166 enum class DetachType { Remove, Swap };
167 167
168 // This frame has been detached from the view, but has not been closed yet. 168 // This frame has been detached from the view, but has not been closed yet.
169 virtual void frameDetached(WebFrame*, DetachType) { } 169 virtual void frameDetached(WebFrame*, DetachType) { }
170 170
171 // This frame has become focused.. 171 // This frame has become focused..
172 virtual void frameFocused() { } 172 virtual void frameFocused() { }
173 173
174 // This frame is about to be closed. This is called after frameDetached, 174 // This frame is about to be closed. This is called after frameDetached,
175 // when the document is being unloaded, due to new one committing. 175 // when the document is being unloaded, due to new one committing.
176 virtual void willClose(WebFrame*) { } 176 virtual void willClose(WebFrame*) { }
177 177
178 // This frame's name has changed. 178 // This frame's name has changed.
179 virtual void didChangeName(WebLocalFrame*, const WebString&) { } 179 virtual void didChangeName(WebLocalFrame*, const WebString& name, const WebS tring& uniqueName) { }
180 180
181 // This frame has been set to enforce strict mixed content checking. 181 // This frame has been set to enforce strict mixed content checking.
182 virtual void didEnforceStrictMixedContentChecking() {} 182 virtual void didEnforceStrictMixedContentChecking() {}
183 183
184 // The sandbox flags have changed for a child frame of this frame. 184 // The sandbox flags have changed for a child frame of this frame.
185 virtual void didChangeSandboxFlags(WebFrame* childFrame, WebSandboxFlags fla gs) { } 185 virtual void didChangeSandboxFlags(WebFrame* childFrame, WebSandboxFlags fla gs) { }
186 186
187 // Some frame owner properties have changed for a child frame of this frame. 187 // Some frame owner properties have changed for a child frame of this frame.
188 // Frame owner properties currently include: scrolling, marginwidth and 188 // Frame owner properties currently include: scrolling, marginwidth and
189 // marginheight. 189 // marginheight.
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
700 // This method takes ownership of the callbacks pointer. 700 // This method takes ownership of the callbacks pointer.
701 virtual void checkIfAudioSinkExistsAndIsAuthorized(const WebString& sinkId, const WebSecurityOrigin&, WebSetSinkIdCallbacks*) { BLINK_ASSERT_NOT_REACHED(); } 701 virtual void checkIfAudioSinkExistsAndIsAuthorized(const WebString& sinkId, const WebSecurityOrigin&, WebSetSinkIdCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
702 702
703 protected: 703 protected:
704 virtual ~WebFrameClient() { } 704 virtual ~WebFrameClient() { }
705 }; 705 };
706 706
707 } // namespace blink 707 } // namespace blink
708 708
709 #endif 709 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698