Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3
Patch Set: Addressed CR feedback from Charlie. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 void cancelPendingScopingEffort() override; 251 void cancelPendingScopingEffort() override;
252 void increaseMatchCount(int count, int identifier) override; 252 void increaseMatchCount(int count, int identifier) override;
253 void resetMatchCount() override; 253 void resetMatchCount() override;
254 int findMatchMarkersVersion() const override; 254 int findMatchMarkersVersion() const override;
255 WebFloatRect activeFindMatchRect() override; 255 WebFloatRect activeFindMatchRect() override;
256 void findMatchRects(WebVector<WebFloatRect>&) override; 256 void findMatchRects(WebVector<WebFloatRect>&) override;
257 int selectNearestFindMatch(const WebFloatPoint&, WebRect* selectionRect) ove rride; 257 int selectNearestFindMatch(const WebFloatPoint&, WebRect* selectionRect) ove rride;
258 void setTickmarks(const WebVector<WebRect>&) override; 258 void setTickmarks(const WebVector<WebRect>&) override;
259 259
260 // WebFrameImplBase methods: 260 // WebFrameImplBase methods:
261 void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name, const AtomicString& fallbackName) override; 261 void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name, const AtomicString& uniqueName) override;
262 LocalFrame* frame() const override { return m_frame.get(); } 262 LocalFrame* frame() const override { return m_frame.get(); }
263 263
264 void willBeDetached(); 264 void willBeDetached();
265 void willDetachParent(); 265 void willDetachParent();
266 266
267 static WebLocalFrameImpl* create(WebTreeScopeType, WebFrameClient*); 267 static WebLocalFrameImpl* create(WebTreeScopeType, WebFrameClient*);
268 static WebLocalFrameImpl* createProvisional(WebFrameClient*, WebRemoteFrame* , WebSandboxFlags, const WebFrameOwnerProperties&); 268 static WebLocalFrameImpl* createProvisional(WebFrameClient*, WebRemoteFrame* , WebSandboxFlags, const WebFrameOwnerProperties&);
269 ~WebLocalFrameImpl() override; 269 ~WebLocalFrameImpl() override;
270 270
271 PassRefPtrWillBeRawPtr<LocalFrame> createChildFrame(const FrameLoadRequest&, const AtomicString& name, HTMLFrameOwnerElement*); 271 PassRefPtrWillBeRawPtr<LocalFrame> createChildFrame(const FrameLoadRequest&, const AtomicString& name, HTMLFrameOwnerElement*);
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 // cleared upon close(). 407 // cleared upon close().
408 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive; 408 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive;
409 #endif 409 #endif
410 }; 410 };
411 411
412 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame()); 412 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame());
413 413
414 } // namespace blink 414 } // namespace blink
415 415
416 #endif 416 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698